Layer data enhancements #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-implements layer data serialisation and parsing, and column accessors.
Serialisation
Geometries are flattened into arrays of flat coordinates. This format is significantly faster to serialise with jsonlite (points are roughly the same), allows for deck.gl optimisation for paths and polygons, and fixes js memory issues flattening large multi-geometry tables.
Serialisation is no longer dependent on {sf} internal geometry representation. Uses {wk}'s vertex filter.
Parsing
Layer data types are now dynamically resolved in browser using dataTransform and accessors with embedded conditionals. External json files may now be formatted as either row-major, or the much better column-major.