Remove feature request storage

qgis · Nov 14, 2024 · 72e215b · 72e215b
1 parent 74c5089
commit 72e215b
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 5 deletions.
diff --git a/src/gui/qgsrelationeditorwidget.cpp b/src/gui/qgsrelationeditorwidget.cpp
@@ -676,7 +676,6 @@ void QgsRelationEditorWidget::updateUiSingleEdit()
     updateButtons();
   }
 
-  mFeatureRequest = request;
 }
 
 void QgsRelationEditorWidget::updateUiMultiEdit()

diff --git a/src/gui/qgsrelationeditorwidget.h b/src/gui/qgsrelationeditorwidget.h
@@ -267,9 +267,6 @@ class GUI_EXPORT QgsRelationEditorWidget : public QgsAbstractRelationEditorWidge
     bool mAllowAddChildFeatureWithNoGeometry = true;
     QString mFilterExpression;
 
-    // Mainly used for testing purposes
-    QgsFeatureRequest mFeatureRequest;
-
     QList<QTreeWidgetItem *> mMultiEditPreviousSelectedItems;
     QgsFeatureIds mMultiEdit1NJustAddedIds;
 

diff --git a/tests/src/gui/testqgsrelationeditorwidget.cpp b/tests/src/gui/testqgsrelationeditorwidget.cpp
@@ -307,7 +307,7 @@ void TestQgsRelationEditorWidget::testFeatureRequest()
   relationEditorWidget.setEditorContext( context );
 
   relationEditorWidget.updateUiSingleEdit();
-  QCOMPARE( relationEditorWidget.mFeatureRequest.filterExpression()->expression(), QStringLiteral( "\"pk\" IN (10,11)" ) );
+  QCOMPARE( relationEditorWidget.mDualView->masterModel()->request().filterExpression()->expression(), QStringLiteral( "\"pk\" IN (10,11)" ) );
 }
 
 void TestQgsRelationEditorWidget::testUpdateUi()