Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MSSQL connection string backslash syntax #59385

Closed
wants to merge 3 commits into from
Closed

Conversation

Geojim
Copy link

@Geojim Geojim commented Nov 8, 2024

Fixes 59264

Adds brackets to table connection string to fix issue with '' in username based schema (Domain\User) throwing errors

Minor edits to syntax handling - strings tested with orginfo

… special characters

The MS SQL provider currently uses quotes for schema names which fails when the schema contains special characters like backslashes. This PR changes the quoting to use SQL Server's bracket notation ([schema_name]) which properly handles special characters.
@github-actions github-actions bot added this to the 3.42.0 milestone Nov 8, 2024
Copy link

github-actions bot commented Nov 10, 2024

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 69ca272)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 69ca272)

@Geojim
Copy link
Author

Geojim commented Nov 10, 2024

Not working.... DSN connections seem to be a problem now

@Geojim Geojim closed this Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQL Server can't add layers from schema with '\' backslash in them
1 participant