Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge remote and local QgsCopcPointCloudIndex classes #59418

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

dvdkon
Copy link
Contributor

@dvdkon dvdkon commented Nov 12, 2024

Description

This PR follows #59279, implementing another part of qgis/QGIS-Enhancement-Proposals#290: It removes QgsRemoteCopcPointCloudIndex, putting its code into QgsCopcPointCloudIndex, which can now be used for both remote and local data.

@github-actions github-actions bot added this to the 3.42.0 milestone Nov 12, 2024
Copy link

github-actions bot commented Nov 12, 2024

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit ed004d8)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit ed004d8)

@dvdkon dvdkon marked this pull request as ready for review November 12, 2024 21:08
Copy link
Member

@wonder-sk wonder-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cleanup!

src/core/pointcloud/qgscopcpointcloudindex.cpp Outdated Show resolved Hide resolved
@wonder-sk wonder-sk merged commit daf91f1 into qgis:master Nov 14, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants