Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh editing delaunay refinement #59560

Merged
merged 19 commits into from
Jan 8, 2025

Conversation

JanCaha
Copy link
Contributor

@JanCaha JanCaha commented Nov 22, 2024

Description

This adds optional setting for adding Mesh Vertex in Face. This allows to refine triangular Faces in neighborhood of the face that had the vertex added. Edges of those faces are checked if they satisfy Delaunay condition and if the not the edge is flipped.

UI:
2025-01-08-13-37-42

Usage:
Peek 2025-01-08 13-48

@github-actions github-actions bot added this to the 3.42.0 milestone Nov 22, 2024
Copy link

github-actions bot commented Nov 22, 2024

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit a7ec33d)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit a7ec33d)

Copy link

github-actions bot commented Dec 7, 2024

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Dec 7, 2024
@nyalldawson nyalldawson removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Dec 9, 2024
Copy link
Contributor

@uclaros uclaros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition!
Just a few comments here and there :)

src/app/mesh/qgsmaptooleditmeshframe.cpp Outdated Show resolved Hide resolved
src/core/mesh/qgsmesheditor.cpp Outdated Show resolved Hide resolved
src/core/mesh/qgsmesheditor.cpp Outdated Show resolved Hide resolved
src/core/mesh/qgsmesheditor.cpp Show resolved Hide resolved
src/core/mesh/qgsmesheditor.h Show resolved Hide resolved
src/core/mesh/qgsmesheditor.h Outdated Show resolved Hide resolved
src/core/mesh/qgsmesheditor.h Outdated Show resolved Hide resolved
JanCaha and others added 7 commits December 23, 2024 16:12
Co-authored-by: Stefanos Natsis <uclaros@gmail.com>
Co-authored-by: Stefanos Natsis <uclaros@gmail.com>
Co-authored-by: Stefanos Natsis <uclaros@gmail.com>
@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 8, 2025
@qgis qgis deleted a comment from github-actions bot Jan 8, 2025
@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 8, 2025
@uclaros uclaros added the Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. label Jan 8, 2025
@uclaros uclaros added the Changelog Items that are queued to appear in the visual changelog - remove after harvesting label Jan 8, 2025
@qgis-bot
Copy link
Collaborator

qgis-bot commented Jan 8, 2025

@JanCaha

This pull request has been tagged for the changelog.

  • The description will be harvested so please provide a "nearly-ready" text for the final changelog
  • If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
  • If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits
  • Funded by NAME
  • Funded by URL
  • Funded by NAME URL
  • Sponsored by NAME
  • Sponsored by URL
  • Sponsored by NAME URL

Thank you!

@qgis-bot
Copy link
Collaborator

qgis-bot commented Jan 8, 2025

@JanCaha
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

Copy link
Contributor

@uclaros uclaros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a couple of screenshots for the new UI and new expected behavior?

@JanCaha
Copy link
Contributor Author

JanCaha commented Jan 8, 2025

@uclaros

Would the added images work?

@uclaros uclaros merged commit 67bc6af into qgis:master Jan 8, 2025
39 checks passed
@qgis-bot
Copy link
Collaborator

qgis-bot commented Jan 8, 2025

@JanCaha
A documentation ticket has been opened at qgis/QGIS-Documentation#9533
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog Items that are queued to appear in the visual changelog - remove after harvesting Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants