Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3D] Fix reset view button #60413

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Withalion
Copy link
Contributor

Description

This PR fixes reset view button giving wrong camera positions for virtual point clouds, and also fixes a bug where resetting view multiple times would set near & far planes incorrectly. Also it fixes initial position setting of camera after opening 3D view, which should be set to top down view of whole scene.

@github-actions github-actions bot added this to the 3.42.0 milestone Feb 3, 2025
Copy link

github-actions bot commented Feb 3, 2025

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit f4c943c)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit f4c943c)

Copy link

github-actions bot commented Feb 3, 2025

Tests failed for Qt 6

One or more tests failed using the build from commit 8d3bb95

virtual_pointcloud_3d_overview (testPointCloud3DOverview)

virtual_pointcloud_3d_overview

Test failed at testPointCloud3DOverview at tests/src/3d/testqgspointcloud3drendering.cpp:603

The full test report (included comparison of rendered vs expected images) can be found here.

Further documentation on the QGIS test infrastructure can be found in the Developer's Guide.

Copy link

github-actions bot commented Feb 3, 2025

Tests failed for Qt 5

One or more tests failed using the build from commit 3455251

virtual_pointcloud_3d_overview (testPointCloud3DOverview)

virtual_pointcloud_3d_overview

Test failed at testPointCloud3DOverview at tests/src/3d/testqgspointcloud3drendering.cpp:603

The full test report (included comparison of rendered vs expected images) can be found here.

Further documentation on the QGIS test infrastructure can be found in the Developer's Guide.

@Withalion
Copy link
Contributor Author

Withalion commented Feb 4, 2025

To correct myself, the feature to open the 3D scene in the same place as 2D scene is currently looking at stays. It just fixes the bug for smaller scenes where this "zoom" would move camera to point to empty space.
EDIT: fixes only reset view button not the initial position bug

@Withalion Withalion changed the title [3D] Fix reset view button & initial position [3D] Fix reset view button Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants