Fix clang-tidy ci #60659
Fix clang-tidy ci #60659
Conversation
ptitjano
force-pushed
the
fix-clang-tidy-ci
branch
from
8a4c06a to
841acd9
Compare
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
There was a problem hiding this comment.
Thank you to take the time to get to the bottom of that!
I imagine that we will get some issues when we will build QGIS with clang 16, no?
I just added "NOT FOR MERGE" label to avoid merging this PR before you remove the test commit. You can get rid of it and merge once everything is OK.
…4.04 At the moment the clang-tidy CI fails on each file with the following message: ``` error: PCH file uses an older PCH format that is no longer supported [clang-diagnostic-error] ``` This is because clang-tidy version 18 is used while QGIS compilation is achieved with clang 15. Indeed, QGIS is built with clazy support which relies on clang 15. This issue is fixed by using clang version 15 instead of version 18 in `docker-qgis-clangtidy.sh`.
This script is already part of the of the `clang-tidy-15` package
ptitjano
force-pushed
the
fix-clang-tidy-ci
branch
from
841acd9 to
80f56e4
Compare
ptitjano
force-pushed
the
fix-clang-tidy-ci
branch
from
80f56e4 to
cd46062
Compare
|
clang-tidy CI now correctly detects an error: https://github.com/qgis/QGIS/actions/runs/13394386771/job/37413710375?pr=60659 |
ptitjano
force-pushed
the
fix-clang-tidy-ci
branch
from
cd46062 to
f9e2fd7
Compare
|
I have now removed the test commit. This PR is ready. |
Yes, we need to update the clang version every time the ubuntu CI is updated. |
Description
At the moment the clang-tidy CI fails on each file with the following
message:
This is because clang-tidy version 18 is used while QGIS
compilation is achieved with clang 15. Indeed, QGIS is built with
clazy support which relies on clang 15.
This issue is fixed by using clang version 15 instead of version 18 in
docker-qgis-clangtidy.sh.The 3rd commit should be removed before merge. It is only present to check that the CI detects errors correctly.