maintenance: h5py.default_file_mode is deprecated #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting Qiita, the log reports about a deprecated use of
h5py.get_config().default_file_mode = 'r'
. This function was indeed deprecated with version 3.0.0. I therefore use thepackaging
lib to check if the used h5py version is older than that before trying to manually set to 'r'.Should you feel we anyways would not use older h5py versions, we can delete these lines 15-20 in
qiita_files/util.py
altogether