escape(error) (#3343)

* escape(error) * fix TestPublicHandler
qiita-spots · Jan 3, 2024 · b021f8a · b021f8a
1 parent b0d12fb
commit b021f8a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/qiita_pet/templates/error.html b/qiita_pet/templates/error.html
@@ -1,8 +1,7 @@
 {% extends sitebase.html %}
-{% autoescape None %}
 {% block content%}
     <h1 style="text-align:center">ERROR: CODE {{status_code}}!</h1>
-    <h2 style="text-align:center">{{error}}!</h2>
+    <h2 style="text-align:center">{% raw escape(error) %}</h2>
     <p style="text-align:center">The error has been logged and will be looked at.</p>
     <p style="text-align:center">Need help? Send us an <a href="mailto:qiita.help@gmail.com">email</a>.</p>
     {% if is_admin %}

diff --git a/qiita_pet/test/test_public.py b/qiita_pet/test/test_public.py
@@ -21,12 +21,12 @@ def test_public(self):
 
         response = self.get('/public/?study_id=100')
         self.assertEqual(response.code, 422)
-        self.assertIn("Study 100 doesn't exist",
+        self.assertIn("Study 100 doesn&#39;t exist",
                       response.body.decode('ascii'))
 
         response = self.get('/public/?artifact_id=100')
         self.assertEqual(response.code, 422)
-        self.assertIn("Artifact 100 doesn't exist",
+        self.assertIn("Artifact 100 doesn&#39;t exist",
                       response.body.decode('ascii'))
 
         response = self.get('/public/?artifact_id=1')
@@ -58,7 +58,7 @@ def test_public(self):
 
         response = self.get('/public/?artifact_id=8')
         self.assertEqual(response.code, 422)
-        self.assertIn("Artifact 8 doesn't belong to a study",
+        self.assertIn("Artifact 8 doesn&#39;t belong to a study",
                       response.body.decode('ascii'))