fix #3300 #3309
fix #3300 #3309
Conversation
| # If the investigation_type is None let's add it based on the | ||
| # data_type being created - if possible | ||
| if investigation_type is None: | ||
| if data_type_str in {'16S', '18S', 'ITS'}: |
There was a problem hiding this comment.
It might be good to do this as an enumerated type like we do in metapool and whatnot, but I can go either way.
There was a problem hiding this comment.
Do you mean like this: https://docs.python.org/3/library/enum.html ? If not, what do you mean? Also, I'm not sure of the benefits of going that route, could you expand?
There was a problem hiding this comment.
We usually do it like this: https://github.com/charles-cowart/metagenomics_pooling_notebook/blob/1fa87c859735289a8922d8906b2289e0993f935e/metapool/metapool.py#L16 but perhaps using Enum would be better.
It's something Daniel asks a lot for. My take on it is that it makes it easier to add/change to the list.
There was a problem hiding this comment.
Under the DRY principle, unless this type of test is truly only done once ever
There was a problem hiding this comment.
Got it! ... and that comment made me remember TARGET_GENE_DATA_TYPES; changing for that.
No description provided.