-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Resource allocation plots in util.py #3382
PR: Resource allocation plots in util.py #3382
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, a few comments/requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but it will be great if @charles-cowart can also do a pass. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions.
@Gossty it might be good to change the name of this PR if it's no longer a WIP and no longer just an initial commit. |
qiita_db/util.py
Outdated
|
||
ax = axs[0] | ||
# models for memory | ||
mem_model1 = (lambda x, k, a, b: k * np.log(x) + x * a + b) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not desirable to have these defined once in utils and once in tests. If you need them for tests, I would suggest moving them out of this function and defining them at the top of util.py. Then you can still use them in this function, but you can also import them into test_util.py (actually I think you just need to import the model_mem and model_time arrays) and use them there. In that way you're treating util.py as the place to go to define and get that information. Currently you have to know that this is defined in two places and make changes to both as needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for all your hard work!
No description provided.