make help email address configurable instead of hard coding

qiita_core/configuration_manager.py

@@ -119,10 +119,8 @@ class ConfigurationManager(object):
         The path to the directory containing the plugin configuration files
     help_email : str
         The email address a user should write to when asking for help
-        Defaults to qiita.help@gmail.com
     sysadmin_email : str
         The email address, Qiita sends internal notifications to a sys admin
-        Defaults to jdereus@health.ucsd.edu
 
     Raises
     ------
@@ -247,6 +245,11 @@ def _get_main(self, config):
                 "section of Qiita's config file. This address is essential "
                 "for users to ask for help as it is displayed at various "
                 "location throughout Qiita's web pages.")
+        if (self.help_email == 'foo@bar.com') and \
+           (self.test_environment is False):
+            warnings.warn(
+                "Using the github fake email for HELP_EMAIL, "
+                "are you sure this is OK?")
 
         self.sysadmin_email = config.get('main', 'SYSADMIN_EMAIL')
         if not self.sysadmin_email:
@@ -255,6 +258,11 @@ def _get_main(self, config):
                 "section of Qiita's config file. Serious issues will "
                 "automatically be reported to a sys admin, an according "
                 "address is therefore required!")
+        if (self.sysadmin_email == 'jeff@bar.com') and \
+           (self.test_environment is False):
+            warnings.warn(
+                "Using the github fake email for SYSADMIN_EMAIL, "
+                "are you sure this is OK?")
 
     def _get_job_scheduler(self, config):
         """Get the configuration of the job_scheduler section"""

qiita_core/support_files/config_test.cfg

@@ -69,10 +69,10 @@ COOKIE_SECRET = SECRET
 JWT_SECRET = SUPER_SECRET
 
 # Address a user should write to when asking for help
-HELP_EMAIL = qiita.help@gmail.com
+HELP_EMAIL = foo@bar.com
 
 # The email address, Qiita sends internal notifications to a sys admin
-SYSADMIN_EMAIL = jdereus@health.ucsd.edu
+SYSADMIN_EMAIL = jeff@bar.com
 
 # ----------------------------- SMTP settings -----------------------------
 [smtp]

qiita_core/tests/test_configuration_manager.py

@@ -29,7 +29,7 @@ def setUp(self):
 
         self.conf = ConfigParser()
         with open(self.conf_fp, newline=None) as f:
-            self.conf.readfp(f)
+            self.conf.read_file(f)
 
     def tearDown(self):
         if self.old_conf_fp is not None:
@@ -132,6 +132,8 @@ def test_get_main(self):
 
         # Warning raised if No files will be allowed to be uploaded
         # Warning raised if no cookie_secret
+        self.conf.set('main', 'HELP_EMAIL', 'ignore@me')
+        self.conf.set('main', 'SYSADMIN_EMAIL', 'ignore@me')
         with warnings.catch_warnings(record=True) as warns:
             obs._get_main(self.conf)
 
@@ -183,9 +185,21 @@ def test_get_main(self):
     def test_help_email(self):
         obs = ConfigurationManager()
 
-        obs._get_main(self.conf)
-        self.assertEqual(obs.help_email, 'foo@bar.com')
-        self.assertEqual(obs.sysadmin_email, 'jeff@bar.com')
+        with warnings.catch_warnings(record=True) as warns:
+            # warning get only issued when in non test environment
+            self.conf.set('main', 'TEST_ENVIRONMENT', 'FALSE')
+
+            obs._get_main(self.conf)
+            self.assertEqual(obs.help_email, 'foo@bar.com')
+            self.assertEqual(obs.sysadmin_email, 'jeff@bar.com')
+
+            obs_warns = [str(w.message) for w in warns]
+            exp_warns = [
+                'Using the github fake email for HELP_EMAIL, '
+                'are you sure this is OK?',
+                'Using the github fake email for SYSADMIN_EMAIL, '
+                'are you sure this is OK?']
+            self.assertCountEqual(obs_warns, exp_warns)
 
         # test if it falls back to qiita.help@gmail.com
         self.conf.set('main', 'HELP_EMAIL', '')