-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Purge non-verified user #3417
Purge non-verified user #3417
Conversation
…ed and offer means to delete those
@sjanssen2, could you pull from dev and update this branch? Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment that I completely missed in my original review. Thanks.
|
||
UPDATE qiita.qiita_user SET creation_timestamp = '2015-12-03 13:52:42.751331-07' WHERE email = 'test@foo.bar'; | ||
|
||
-- Jun 20, 2024 | ||
-- Add some non-verified users to the test DB to test new admin page: /admin/purge_users/ | ||
|
||
INSERT INTO qiita.qiita_user VALUES ('justnow@nonvalidat.ed', 5, '$2a$12$gnUi8Qg.0tvW243v889BhOBhWLIHyIJjjgaG6dxuRJkUM8nXG9Efe', 'JustNow', 'NonVeriUser', '1634 Edgemont Avenue', '303-492-1984', NULL, NULL, NULL, false, NULL, NULL, NULL, NOW()); | ||
INSERT INTO qiita.qiita_user VALUES ('ayearago@nonvalidat.ed', 5, '$2a$12$gnUi8Qg.0tvW243v889BhOBhWLIHyIJjjgaG6dxuRJkUM8nXG9Efe', 'Oldie', 'NonVeriUser', '172 New Lane', '102-111-1984', NULL, NULL, NULL, false, NULL, NULL, NULL, NOW() - INTERVAL '1 YEAR'); | ||
INSERT INTO qiita.qiita_user VALUES ('3Xdays@nonvalidat.ed', 5, '$2a$12$gnUi8Qg.0tvW243v889BhOBhWLIHyIJjjgaG6dxuRJkUM8nXG9Efe', 'TooLate', 'NonVeriUser', '564 C Street', '508-492-222', NULL, NULL, NULL, false, NULL, NULL, NULL, NOW() - INTERVAL '30 DAY'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for not catching this before but could you move these lines to patches/test_db_sql/92.sql. The issue is that if we leave them here they will also be inserted in the main deployment but in patches/test_db_sql
they will only be applied to the test environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, I think this is the source of the error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed that, makes total sense to me. I also know a guy who complained about test data leftovers in a fresh production DB ;-)
I am a bit puzzled about the current DB error raised in the tests. It looks to me like the portals test does not clean up properly for tearDown. In my attempt to reproduce this issue locally, all tests passed when executed once, but re-running those caused the same errors as in github. However, I wonder why this becomes an issue now and not already earlier. Any ideas @antgonza ? |
1634 Edgemont Avenue - the address of one of the original donors to
UBiome - haha
…On Thu, Jun 20, 2024 at 5:52 AM Stefan Janssen ***@***.***> wrote:
I am a bit puzzled about the current DB error raised in the tests. It
looks to me like the portals test does not clean up properly for tearDown.
In my attempt to reproduce this issue locally, all tests passed when
executed once, but re-running those caused the same errors as in github.
However, I wonder why this becomes an issue now and not already earlier.
Any ideas @antgonza <https://github.com/antgonza> ?
—
Reply to this email directly, view it on GitHub
<#3417 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPL3AFLGZZDQRD2IBQMWDTZILF7RAVCNFSM6AAAAABJSGQRXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBQGU4TKMBXGY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Gail Ackermann
Lab Co-ordinator
Knight Lab
UCSD
303-889-9763
***@***.*** ***@***.***>
|
I might got the problem. Adding three new test users caused more iterations of this loop Lines 89 to 94 in 8b3f717
qiita/qiita_db/test/test_portal.py Line 51 in 8b3f717
|
Handle #3416 first!
Addressing #3378 as well.
This PR is based on user creation_timestamp logging and offers a new Admin only page that lists those users that
a) are non yet verifier (i.e. user_status_id==5) and
b) where registers more than 30 days ago (give a new user sufficient time to react)
Individual or all users can be selected in the website and removed by one click.