Skip to content

Commit

Permalink
Fix the wrong service-worker mode. (WICG#733)
Browse files Browse the repository at this point in the history
  • Loading branch information
qingxinwu authored Aug 28, 2023
1 parent 4159e19 commit 09c97ee
Showing 1 changed file with 15 additions and 10 deletions.
25 changes: 15 additions & 10 deletions spec.bs
Original file line number Diff line number Diff line change
Expand Up @@ -349,8 +349,6 @@ To <dfn>check interest group permissions</dfn> given an [=origin=]
:: «`Accept`: `application/json`»
: [=request/client=]
:: `null`
: [=request/service-workers mode=]
:: "`none`"
: [=request/origin=]
:: |frameOrigin|
: [=request/mode=]
Expand All @@ -361,6 +359,9 @@ To <dfn>check interest group permissions</dfn> given an [=origin=]
:: "`omit`"
: [=request/redirect mode=]
:: "`error`"

Issue: One of the side-effects of a `null` client for this subresource request is it neuters all
service worker interceptions, despite not having to set the service workers mode.
1. Let |resource| be null.
1. [=Fetch=] |request| with [=fetch/useParallelQueue=] set to true, and
[=fetch/processResponseConsumeBody=] set to the following steps given a [=response=] |response|
Expand Down Expand Up @@ -1532,8 +1533,6 @@ To <dfn>fetch script</dfn> given a [=URL=] |url|:
:: «`Accept`: `text/javascript`»
: [=request/client=]
:: `null`
: [=request/service-workers mode=]
:: "`none`"
: [=request/mode=]
:: "`no-cors`"
: [=request/referrer=]
Expand All @@ -1542,6 +1541,9 @@ To <dfn>fetch script</dfn> given a [=URL=] |url|:
:: "`omit`"
: [=request/redirect mode=]
:: "`error`"

Issue: One of the side-effects of a `null` client for this subresource request is it neuters all
service worker interceptions, despite not having to set the service workers mode.
1. Let |script| be null.
1. [=Fetch=] |request| with [=fetch/useParallelQueue=] set to true, and
[=fetch/processResponseConsumeBody=] set to the following steps given a [=response=] |response|
Expand All @@ -1563,8 +1565,6 @@ To <dfn>fetch WebAssembly</dfn> given a [=URL=] |url|:
:: «`Accept`: `application/wasm`»
: [=request/client=]
:: `null`
: [=request/service-workers mode=]
:: "`none`"
: [=request/mode=]
:: "`no-cors`"
: [=request/referrer=]
Expand All @@ -1573,6 +1573,9 @@ To <dfn>fetch WebAssembly</dfn> given a [=URL=] |url|:
:: "`omit`"
: [=request/redirect mode=]
:: "`error`"

Issue: One of the side-effects of a `null` client for this subresource request is it neuters all
service worker interceptions, despite not having to set the service workers mode.
1. Let |moduleObject| be null.
1. [=Fetch=] |request| with [=fetch/processResponseConsumeBody=] set to the following steps given
a [=response=] |response| and null, failure, or a [=byte sequence=] |responseBody|:
Expand Down Expand Up @@ -1602,8 +1605,6 @@ To <dfn>fetch trusted signals</dfn> given a [=URL=] |url|, and a [=boolean=] |is
:: «`Accept`: `application/json`»
: [=request/client=]
:: `null`
: [=request/service-workers mode=]
:: "`none`"
: [=request/mode=]
:: "`no-cors`"
: [=request/referrer=]
Expand All @@ -1612,6 +1613,9 @@ To <dfn>fetch trusted signals</dfn> given a [=URL=] |url|, and a [=boolean=] |is
:: "`omit`"
: [=request/redirect mode=]
:: "`error`"

Issue: One of the side-effects of a `null` client for this subresource request is it neuters all
service worker interceptions, despite not having to set the service workers mode.
1. Let |signals| be null.
1. Let |dataVersion| be null.
1. Let |formatVersion| be null.
Expand Down Expand Up @@ -2628,8 +2632,6 @@ The <dfn for=Navigator method>updateAdInterestGroups()</dfn> method steps are:
:: «`Accept`: `application/json`»
: [=request/client=]
:: `null`
: [=request/service-workers mode=]
:: "`none`"
: [=request/mode=]
:: "`no-cors`"
: [=request/referrer=]
Expand All @@ -2638,6 +2640,9 @@ The <dfn for=Navigator method>updateAdInterestGroups()</dfn> method steps are:
:: "`omit`"
: [=request/redirect mode=]
:: "`error`"

Issue: One of the side-effects of a `null` client for this subresource request is it neuters
all service worker interceptions, despite not having to set the service workers mode.
1. Let |update| be null.
1. [=Fetch=] |request| with [=fetch/useParallelQueue=] set to true, and
[=fetch/processResponseConsumeBody=] set to the following steps given a [=response=] |response|
Expand Down

0 comments on commit 09c97ee

Please sign in to comment.