Downsampling forDebuggingOnly reports. #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build error says there are multiple utf-8. Need to add a default link to set which one to link to
|
@brusshamilton, mind taking a look? This is on top of the parent PR for forDebuggingOnly API. Not sure the best way to do it, but it seems I need to create a PR to merge to the parent branch, instead of to the main branch, to only show the changes made on top of its parent PR. So doing the review here and will a create a PR to the turtledove repo once its parent PR is merged. |
When joining IGs with unrecognized modes, we use "compatibility" for forward compatibility. Seems like we should do the same for updates. Note that neither this behavior nor the originally described behavior are what currently happens - we currently ignore unrecognized modes. Want to get approval for this before changing behvaior.
…on mechanism (WICG#1004) * Spec increase limit 20 -> 40, and also feature detection * Exposed + fix invalid plural --------- Co-authored-by: Maks Orlovich <morlovich@chromium.org>
* Spec forDebuggingOnly APIs. * [Spec] Add forDebuggingOnly API. * finish * Some fixes. * Fixes. * Address comments. Add reporting helper. * Fix problems. * small fixes. * update a comment for [=no bid=] * indent fix. * fix more indent * Address comments * revert some unrelated fixes/cleanups * one more tiny revert * Add an id field to generated bid * small fix * Add an issue for generatedBids. * link to an issue. * Apply suggestions from code review Co-authored-by: Dominic Farolino <domfarolino@gmail.com> * Address comments --------- Co-authored-by: Qingxin Wu <qingxinwu@google.com> Co-authored-by: Dominic Farolino <domfarolino@gmail.com>
|
moving this PR to turtledove repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of the parent PR for forDebuggingOnly API. Not sure the best way to do it, but it seems I need to create a PR to merge to the parent branch, instead of to the main branch, to actually only show the changes made on top of its parent PR.