fix(Checkbox): v-model cannot be listened by watch

see: hug-sun#484
qiqingfu · Dec 14, 2020 · 1888754 · 1888754
1 parent 49e1d98
commit 1888754
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/packages/element3/packages/checkbox/uses.js b/packages/element3/packages/checkbox/uses.js
@@ -35,12 +35,17 @@ export function useModel() {
     set({ label, checked }) {
       if (label && isArray(model.value)) {
         // when modelValue or elCheckboxGroup.modeValue is array
-        const modelValue = model.value
+        let modelValue = model.value
         const labelIndex = modelValue.indexOf(label)
-        labelIndex === -1 && checked === true && modelValue.push(label)
-        labelIndex !== -1 &&
-          checked === false &&
-          modelValue.splice(labelIndex, 1)
+
+        if (labelIndex === -1 && checked === true) {
+          modelValue = modelValue.concat(label)
+        }
+
+        if (labelIndex !== -1 && checked === false) {
+          modelValue = modelValue.splice(labelIndex, 1)
+        }
+
         state.modelValue = modelValue
         emit('update:modelValue', modelValue)
         dispatch('update:modelValue', modelValue)