Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all other languages other than Spanish and Japanese #327

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Remove all other languages other than Spanish and Japanese #327

merged 2 commits into from
Feb 15, 2024

Conversation

SooluThomas
Copy link
Member

@SooluThomas SooluThomas commented Feb 15, 2024 •
edited by woodsp-ibm
Loading

Summary

Spanish and Japanese are the only languages that was 100% translated & proofread as of Jan 2024

Details and comments

Similar change as qiskit-community/qiskit-machine-learning#766

@woodsp-ibm
Copy link
Member

woodsp-ibm commented Feb 15, 2024 •
edited
Loading

This sort of failure, as the checks are currently were showing, periodically happens. It does some tests that involve data supplied via yfinance package and that data(base) I think is occasionally updated. I will have to check things out and most likely do a PR to fix CI that would need to merge to get this to pass. Strange that last nights CI run did not fail - but then it may have been changed since then.

I took care of it with #328

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7920982748

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 75.939%
Files with Coverage Reduction New Missed Lines %
qiskit_finance/data_providers/wikipedia_data_provider.py 3 68.0%
Totals Coverage Status
Change from base Build 7920960097: 0.1%
Covered Lines: 647
Relevant Lines: 852
💛 - Coveralls

@SooluThomas SooluThomas marked this pull request as ready for review February 15, 2024 21:20
@woodsp-ibm woodsp-ibm added stable backport potential The bug might be minimal and/or import enough to be port to stable type: documentation Issues related to documentation labels Feb 15, 2024
@woodsp-ibm woodsp-ibm merged commit 5ca51fa into qiskit-community:main Feb 15, 2024
15 checks passed
mergify bot pushed a commit that referenced this pull request Feb 15, 2024
@SooluThomas @mergify
Remove all other languages other than Spanish and Japanese (#327)
a3bccf9 
Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
(cherry picked from commit 5ca51fa)
@mergify mergify bot mentioned this pull request Feb 15, 2024
Merged
t-imamichi pushed a commit that referenced this pull request Feb 20, 2024
@SooluThomas @t-imamichi
Remove all other languages other than Spanish and Japanese (#327)
cda3d18 
Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
(cherry picked from commit 5ca51fa)
mergify bot added a commit that referenced this pull request Feb 20, 2024
@mergify @SooluThomas
Remove all other languages other than Spanish and Japanese (#327) (#330)
b658f19 
Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
(cherry picked from commit 5ca51fa)

Co-authored-by: Soolu Thomas <soolu.elto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodsp-ibm woodsp-ibm woodsp-ibm approved these changes

@stefan-woerner stefan-woerner Awaiting requested review from stefan-woerner stefan-woerner is a code owner

@t-imamichi t-imamichi Awaiting requested review from t-imamichi t-imamichi is a code owner

Assignees
No one assigned
Labels
stable backport potential The bug might be minimal and/or import enough to be port to stable type: documentation Issues related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SooluThomas @woodsp-ibm @coveralls