Merge pull request #59 from qld-gov-au/QOLSVC-3224-missing-datastore-…

…link

[QOLSVC-3224] handle any falsy url_type the same way as empty string

ckanext/xloader/helpers.py

@@ -35,8 +35,12 @@ def is_resource_supported_by_xloader(res_dict, check_access=True):
         user_has_access = toolkit.h.check_access('package_update', {'id': res_dict.get('package_id')})
     else:
         user_has_access = True
-    try:
-        is_supported_url_type = res_dict.get('url_type') not in toolkit.h.datastore_rw_resource_url_types()
-    except AttributeError:
-        is_supported_url_type = (res_dict.get('url_type') == 'upload' or res_dict.get('url_type') == '')
+    url_type = res_dict.get('url_type')
+    if url_type:
+        try:
+            is_supported_url_type = url_type not in toolkit.h.datastore_rw_resource_url_types()
+        except AttributeError:
+            is_supported_url_type = (url_type == 'upload')
+    else:
+        is_supported_url_type = True
     return (is_supported_format or is_datastore_active) and user_has_access and is_supported_url_type