Develop to master - fix parsing of mixed single and double quotes #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThrawnCA
commented
May 29, 2023
ThrawnCA
commented
- Increase the sniffing sample size for determining the correct quote character to use.
…otes using tabulator
…gle and double quotes
- This is more efficient than setting it on each call, and applies even to code that just reads the config without accepting an override.
QOLDEV-424 fix parsing of DESBT data
ThrawnCA
requested review from
duttonw,
chris-randall-qol,
RossWebsterWork and
kundupz
duttonw
approved these changes
May 29, 2023
- Added helper for valid xloader formats. - Added condition to display the DataStore tab in Resource Edit.
…tore link in resource read; - Added condition for `datastore_rw_resource_url_types`. - Added DataStore action link to resource read if perms are correct.
…, added new helper; - Added the conditional DataStore action link to more templates. - Added another new helper to handle possible non-existant core helper.
- Combined helpers and conditions into one helper. - Moved `XLoaderFormats` class to utils script to prevent circular imports.
…al-datastore-tab Conditional DataStore Tab in Resource Edit
duttonw
approved these changes
Jun 19, 2023
- Our test IDs don't have the right format, and we should avoid hardcoding IDs anyway
[QOLDEV-424] fix tests to avoid hardcoding resource IDs
- This is intermittently breaking the boston_311 test, when columns load in an unexpected order
[QOLDEV-424] ensure consistent column name ordering in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.