[QOLDEV-490] fix timeout extension #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThrawnCA
commented
Aug 6, 2023
ThrawnCA
commented
- Can't multiply a string by 3, we get repeated text instead of arithmetic multiplication
- Can't multiply a string by 3, we get repeated text instead of arithmetic multiplication
ThrawnCA
requested review from
duttonw,
kundupz,
chris-randall-qol and
RossWebsterWork
- Missed a 'not' when checking if datastore exists
duttonw
approved these changes
Aug 6, 2023
| timeout = timeout * 3 | ||
| # Expand timeout for resources that have to be type-guessed | ||
| timeout = config.get( | ||
| 'ckanext.xloader.job_timeout', |
There was a problem hiding this comment.
can't python to int before multiply?
There was a problem hiding this comment.
It's possible, yes. On the other hand, if the timeout has been explicitly set, we maybe shouldn't change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.