Develop to master - fix overly aggressive date parsing #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use our guessed types to restrict the behaviour of the numeric/timestamp converter, so columns that sniff as text won't be incorrectly partially converted to timestamps
- Apply a regex to limit the values that will potentially be parsed as dates. We aren't interested in anything that doesn't seem to have day, month, or year components.
- Customising the parser requires a lot of boilerplate, and we already have a post-processor to do the job.
[QOLDEV-554] fix overly aggressive timestamp parsing
ThrawnCA
requested review from
duttonw,
kundupz,
chris-randall-qol and
RossWebsterWork
duttonw
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
fun times,
tabulator==1.53.5
https://github.com/frictionlessdata/tabulator-py/releases/tag/v1.53.5 (21 Mar 2021)
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
they suggest to replace with:
https://github.com/frictionlessdata/frictionless-py
Yes. I'm hoping that upstream will do something about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dateutilis too permissive and will accept values that aren't really timestamps.