QOLSVC-2984 Sniff with Windows-1252 encoding rather than Latin-1 #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThrawnCA
requested review from
duttonw,
kundupz,
chris-randall-qol and
RossWebsterWork
duttonw
reviewed
Nov 2, 2023
ckanext/xloader/loader.py
Outdated
| @@ -30,7 +30,7 @@ | |||
| MAX_COLUMN_LENGTH = 63 | |||
| tabulator_config.CSV_SAMPLE_LINES = CSV_SAMPLE_LINES | |||
|
|
|||
| ISO_8859_ENCODING = 'latin1' | |||
| ISO_8859_ENCODING = 'cp1252' | |||
There was a problem hiding this comment.
should rename the iso encoding then.
- Windows-1252 is a superset, which makes it more useful for this purpose
ThrawnCA
force-pushed
the
QOLSVC-2984_non-utf8
branch
from
2e74259
to
cd32d61
Compare
duttonw
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows-1252 is a superset, so it's better for examining an unknown file