Use IDomainObjectModification Implementation #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Develop to master - merge and fix upstream changes
Develop to master - fix parsing of mixed single and double quotes
Develop to master - performance enhancements
Develop to master - fix overly aggressive date parsing
Develop to master - handle null url_type for link resources
Develop to master - add Latin-1 fallback
- Use `IDomainObjectModification` instead of `IResourceUrlChange` for automagic exception handling.
- Check `url_changed`.
ThrawnCA
approved these changes
Nov 16, 2023
|
We can test this out on dev.data.qld.gov.au and pass on any feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(dev): use
IDomainObjectModificationimplementation;IDomainObjectModificationinstead ofIResourceUrlChangefor automagic exception handling.Currently, the
notifymethod from theIResourceUrlChangeimplementation is assuming that the Resource exists in theresource_showaction call. But, at this point, other extensions (namely Validation running in sync mode) can delete the Resource from the session before it is committed. This would do a error here.So using
IDomainObjectModificationinstead, will automagically handle exceptions, logging them, and just passing so that normal operations will resume.