Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cisco WSA #318

Open
wants to merge 1,348 commits into
base: master
Choose a base branch
from
Open

Cisco WSA #318

wants to merge 1,348 commits into from

Conversation

jonathantauman
Copy link

No description provided.

@jonathantauman jonathantauman requested a review from ronh1 February 5, 2023 12:19
ronh1
ronh1 requested changes Feb 6, 2023
View reviewed changes
Copy link

@ronh1 ronh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey!
I finished reviewing your code. It looks great!
Your writing is professional and I have to say that I learned from your code a lot.
Please see my comments and handle the required actions.
The main ideas were about:

  • Using constants (HTTPStatus)
  • Handling errors in the http_request command.
  • Rasing errors - DemsitoException/ValueError - DemisoExceptions relevant in cases when the error comes from the API, ValueError relevant in cases that the errors comes from the arguments :)
    If you want we can speak about all 🦭 :)

@jonathantauman
Copy link
Author

Thanks for the review, very professional and to the point :)

idovandijk and others added 9 commits February 21, 2023 22:23
@idovandijk
Changed PrivateIPs and InternalDomains lists to system (demisto#24783)
a626358 
* Changed lists to system:true

* fixed RN

* Fixed RN to not use banned template

* Added newline at the end of RN

* Newlines everywhere
@content-bot
Update Docker Image To demisto/py3-tools (demisto#24787)
bb3c79a 
* Updated Metadata Of Pack FeedAWS

* Added release notes to pack FeedAWS

* Packs/FeedAWS/Integrations/FeedAWS/FeedAWS.yml Docker image update
@content-bot
Update Docker Image To demisto/armorblox (demisto#24792)
62edc4a 
* Updated Metadata Of Pack Armorblox

* Added release notes to pack Armorblox

* Packs/Armorblox/Integrations/Armorblox/Armorblox.yml Docker image update
@content-bot
Update Docker Image To demisto/graphql (demisto#24793)
9806223 
* Updated Metadata Of Pack BreachRx

* Added release notes to pack BreachRx

* Packs/BreachRx/Integrations/BreachRx/BreachRx.yml Docker image update
@content-bot
Update Docker Image To demisto/taxii-server (demisto#24795)
e95f66b 
* Updated Metadata Of Pack CybleThreatIntel

* Added release notes to pack CybleThreatIntel

* Packs/CybleThreatIntel/Integrations/CybleThreatIntel/CybleThreatIntel.yml Docker image update
@content-bot
Update Docker Image To demisto/pycountry (demisto#24794)
4afd4c1 
* Updated Metadata Of Pack FeedCyCognito

* Added release notes to pack FeedCyCognito

* Packs/FeedCyCognito/Integrations/FeedCyCognito/FeedCyCognito.yml Docker image update
@content-bot
Update Docker Image To demisto/py3-tools (demisto#24791)
82431f5 
* Updated Metadata Of Pack AccentureCTI_Feed

* Added release notes to pack AccentureCTI_Feed

* Packs/AccentureCTI_Feed/Integrations/ACTIIndicatorFeed/ACTIIndicatorFeed.yml Docker image update

* Updated Metadata Of Pack FeedCyjax

* Added release notes to pack FeedCyjax

* Packs/FeedCyjax/Integrations/FeedCyjax/FeedCyjax.yml Docker image update

* Updated Metadata Of Pack FeedGCPWhitelist

* Added release notes to pack FeedGCPWhitelist

* Packs/FeedGCPWhitelist/Integrations/FeedGoogleIPRanges/FeedGoogleIPRanges.yml Docker image update

* Updated Metadata Of Pack FeedMalwareBazaar

* Added release notes to pack FeedMalwareBazaar

* Packs/FeedMalwareBazaar/Integrations/MalwareBazaarFeed/MalwareBazaarFeed.yml Docker image update

* Updated Metadata Of Pack Zabbix

* Added release notes to pack Zabbix

* Packs/Zabbix/Integrations/Zabbix/Zabbix.yml Docker image update
@content-bot
Update Docker Image To demisto/confluent-kafka (demisto#24800)
a642712 
* Updated Metadata Of Pack Kafka

* Added release notes to pack Kafka

* Packs/Kafka/Integrations/KafkaV3/KafkaV3.yml Docker image update
@content-bot
Update Docker Image To demisto/greynoise (demisto#24798)
d3faf94 
* Updated Metadata Of Pack GreyNoise

* Added release notes to pack GreyNoise

* Packs/GreyNoise/Integrations/GreyNoise_Community/GreyNoise_Community.yml Docker image update
yasta5 and others added 10 commits March 6, 2023 12:21
@yasta5
Abnormal security fix array (demisto#25051)
73785cb 
* Fix arraycreate display for ccEmails.

* Added release notes.

* Added changes
@ronh1
Fixing doc review.
ff9ae6c
@ronh1
Fixing integration name.
3ce0fe7
@ronh1
Fixing pack_metadata
16aa03e
@content-bot @capanw @yucohen
EXPANDR-1614 Updating ServiceNow playbook (demisto#24930) (demisto#25090
cea09e2 
)

* Updating ServiceNow playbook

* updating fromversion for expanse attribution

* Updating fromversion

* RN

* Update playbook-ServiceNow_CMDB_Search_README.md

Change default value

* Updating default value

---------

Co-authored-by: Chait A <112722030+capanw@users.noreply.github.com>
Co-authored-by: yucohen <yucohen@paloaltonetworks.com>
@maimorag
adjustments to the pack categories (demisto#24985)
c372388 
* adjustments to the pack categories

* fix
@Ni-Knight
Updated code points in the URL formatter (demisto#25066)
f9d95d5 
* Updated code points in the formatter

* Added a link to living standard code points

* Fixed a line that was too long

* Update FormatURL.py

* RN

* Trailing white spaces

* Update 1_11_41.md
@adi88d
increase Test XDR Playbook retrieve file command timeout (demisto#25069)
74e83ec
@adi88d
increase EvaluateMLModllAtProduction-Test timeout (demisto#25068)
7f8f472
@ronh1
Adding readme file
6292a66
@TalGumi TalGumi removed their assignment Mar 6, 2023
@TalGumi TalGumi removed their request for review March 6, 2023 12:06
RotemAmit and others added 17 commits March 6, 2023 14:13
@RotemAmit @ShirleyDenkberg
Mirroring AWS Security Hub (demisto#24376)
b7bce5f 
* yml updated and incident type

* the start of get remote data

* start get modified remote data

* get_modified_remote_data

* get modified remote data

* starting again get remote data command

* get_remote_data command

* get_mapping_fields_command, readme and yml updates

* severity updates

* updated fetch command and mirroring in

* mapper out and update remote system

* updated mappers

* added incident fields

* mirror out

* more incident fields

* fixed test_fetch_incident

* tests

* tests and mirroring update

* Added the mirroring to the readme

* updated release notes

* fixed build errors

* updated release notes

* fixed first cr notes

* validations error fixes

* updated release notes

* Update Packs/AWS-SecurityHub/Integrations/AWS_SecurityHub/AWS_SecurityHub.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/AWS-SecurityHub/Integrations/AWS_SecurityHub/AWS_SecurityHub.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/AWS-SecurityHub/Integrations/AWS_SecurityHub/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/AWS-SecurityHub/Integrations/AWS_SecurityHub/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/AWS-SecurityHub/Integrations/AWS_SecurityHub/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/AWS-SecurityHub/Integrations/AWS_SecurityHub/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/AWS-SecurityHub/Integrations/AWS_SecurityHub/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/AWS-SecurityHub/Integrations/AWS_SecurityHub/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/AWS-SecurityHub/Integrations/AWS_SecurityHub/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/AWS-SecurityHub/Integrations/AWS_SecurityHub/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/AWS-SecurityHub/Integrations/AWS_SecurityHub/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/AWS-SecurityHub/Integrations/AWS_SecurityHub/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/AWS-SecurityHub/Integrations/AWS_SecurityHub/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/AWS-SecurityHub/Integrations/AWS_SecurityHub/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/AWS-SecurityHub/Integrations/AWS_SecurityHub/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/AWS-SecurityHub/Integrations/AWS_SecurityHub/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/AWS-SecurityHub/Integrations/AWS_SecurityHub/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/AWS-SecurityHub/Integrations/AWS_SecurityHub/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/AWS-SecurityHub/Integrations/AWS_SecurityHub/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/AWS-SecurityHub/Integrations/AWS_SecurityHub/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/AWS-SecurityHub/Integrations/AWS_SecurityHub/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/AWS-SecurityHub/Integrations/AWS_SecurityHub/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/AWS-SecurityHub/ReleaseNotes/1_2_0.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/AWS-SecurityHub/ReleaseNotes/1_2_0.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/AWS-SecurityHub/ReleaseNotes/1_2_0.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/AWS-SecurityHub/ReleaseNotes/1_2_0.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/AWS-SecurityHub/ReleaseNotes/1_2_0.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* updated release notes

* added last_update_to_time

* Update Packs/AWS-SecurityHub/Integrations/AWS_SecurityHub/AWS_SecurityHub.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/AWS-SecurityHub/Integrations/AWS_SecurityHub/AWS_SecurityHub.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/AWS-SecurityHub/Integrations/AWS_SecurityHub/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/AWS-SecurityHub/Integrations/AWS_SecurityHub/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* review updates

* updated release notes

* updated docker image

* updated CommonTypes release notes

* updated marketplace in the layout

* updated theintegration parameters description in the readme

* updated CommonTypes release notes

* added the indicators objects to the incident fields, yml, layout

* updated 2 incident fields

* updated old release notes

* added new lines to json files

* updated release notes

* updated layout

* updated readme

* updated docker image

* cr and some build fixes

* fixed CR comments

* fixed demo comments

* updates to readme and code

* updated docker image

* updated release notes

* fixed

* updated release notes

* updated release notes

* fixed build errors

* fixed build errors

* updated readme

* fixed rc comments

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
@ronh1
Fixing integration name
c7994f6
@mmhw
Retrieve File from Endpoint - Generic V2 Test - Replacing a deprecate…
c58da98 
…d integration (demisto#25054)

* Replacing a deprecated integration

* fix the playbook

* Added RN

* Apply suggestions from code review
@thefrieddan1
Use static CSV instead of downloading it from PhishTank API. (demisto…
da8639b 
…#25055)
@ronh1
Fixing secrets
fe98ecd
@Shellyber
Fix incidentfield sumourl (demisto#25093)
1dae9cb 
* Fix type url

* update pack

* update rn

* update rn
@maimorag
Removing all packs that are not PANW from marketplace (demisto#24992)
c62c518 
* Removing all packs that are not PANW products and that require setting up an instance.

* verifying  all selected packs are removed

* phising pack
@mmhw
increase timeout from 2500 to 3000 (demisto#25097)
a73f685
@ronh1
Updating README
ec9390c
@yaakovpraisler
Fix ParseCSV context output (demisto#25070)
4aee966 
* fix ParseCSV bug

* updated docker and args description

* release notes

* release notes

* fix

* add test

* fix test_data dir

* CR

* conflict
@ronh1
Update README
8441a58
@BEAdi @ShirleyDenkberg
XSOAR Mirroring docs update (demisto#25094)
edf8e83 
* update README

* update mirroring notes

* update description

* Apply suggestions from doc review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
@YuvHayun
1.10.6 (demisto#25045)
f8e368d 
* tests

* new lock

* FIX

* update dockerimage

* version

* change password

* edit circleci config

* artifacts

* 1.10.6

* 1.10.6

* new lock file

---------

Co-authored-by: ilan <ierukhimovic@paloaltonetworks.com>
@ronh1
Merge branch 'contrib/qmasters-ltd_cisco-wsa' into cisco-wsa
0045bb2
@ronh1
Fixing release note description
a1e9814
@ronh1
Fixing release note description
ff6d9c3
@ronh1
Merge branch 'cisco-wsa' of https://github.com/qmasters-ltd/content i…
9dd9e98 
…nto cisco-wsa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TalGumi TalGumi TalGumi requested changes

@ronh1 ronh1 ronh1 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@jonathantauman jonathantauman

@ronh1 ronh1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.