Fix a build warning and tidy up a keymap #24805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waffle87
approved these changes
Jan 10, 2025
milosbugarinovic
pushed a commit
to milosbugarinovic/qmk_firmware
that referenced
this pull request
Jan 13, 2025
gebolze
pushed a commit
to gebolze/qmk_firmware
that referenced
this pull request
Jan 16, 2025
pashashocky
pushed a commit
to pashashocky/qmk
that referenced
this pull request
Jan 17, 2025
vinniefranco
pushed a commit
to Good-Great-Grand-Wonderful/qmk_firmware
that referenced
this pull request
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Also adjusted the default keymap for
keyprez/bisonwhich unnecessarily used custom keycodes (caught after routine Configurator keymap update: qmk/qmk_configurator#1380).Types of Changes
Issues Fixed or Closed by This PR
Checklist