Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rubrehaku #24907

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add Rubrehaku #24907

wants to merge 7 commits into from

Conversation

itsme-zeix
Copy link
Contributor

Description

Add support for Rubrehaku

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • None

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@itsme-zeix itsme-zeix marked this pull request as draft February 9, 2025 05:28
@itsme-zeix itsme-zeix marked this pull request as ready for review February 9, 2025 05:45
@dunk2k
Copy link
Contributor

dunk2k commented Feb 10, 2025

@itsme-zeix
In layout LAYOUT_all, when compared to the other layouts is the missing top right key intentional?

@dunk2k
Copy link
Contributor

dunk2k commented Feb 10, 2025

@itsme-zeix In layout LAYOUT_all, when compared to the other layouts is the missing top right key intentional?

Or should it be that all layouts don't have a top right key? as shown in matrix_diagram.md

If correct, then community_layouts should be removed

@itsme-zeix
Copy link
Contributor Author

itsme-zeix commented Feb 10, 2025

@itsme-zeix In layout LAYOUT_all, when compared to the other layouts is the missing top right key intentional?

Or should it be that all layouts don't have a top right key? as shown in matrix_diagram.md

If correct, then community_layouts should be removed

@dunk2k Thank you. Appreciate the quick review.
All layouts should not have a top right key - though the functionality is identical with or without it. Removing community_layouts makes sense, no wonder I was having compilation issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants