Fix nullness check to src value in MOD32 and DIV32#97
Merged
qmonnet merged 2 commits intoqmonnet:mainfrom Jan 5, 2024
Merged
Conversation
qmonnet
approved these changes
Jan 4, 2024
Owner
qmonnet
left a comment
qmonnet
left a comment
There was a problem hiding this comment.
Looks good, many thanks!
Like for the other PR, I added non-regression tests. Can you please sign-off your commit and update the PR again?
Signed-off-by: Richard Smith <ret2happy@126.com>
We had an issue in the interpreter, because for 32-bit div and mod we would check that the whole (64-bit long) divisor was not 0, but then we'd only use the last 32 bits of this divisor to perform the arithmetic operation. We fixed the bug, but let's add a non-regression test to catch this in the future. Link: qmonnet#95 Link: qmonnet#96 Signed-off-by: Quentin Monnet <quentin@isovalent.com> Signed-off-by: Richard Smith <ret2happy@126.com>
Contributor
Author
|
Updated the patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #95
Fixes #96