Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate addon package to TypeScript #610

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

vscav
Copy link
Member

@vscav vscav commented Oct 9, 2023

This PR migrates the amount-input component to TypeScript. For now, the focus is on the addon package itself. We will migrate the test-app in a later PR (a draft is already available).

Here is the list of tasks that should be completed:

  • Migrate component to TypeScript
  • Add type-checking jobs in CI
  • Add compatibility information about TypeScript in the README
  • QA done in JavaScript and TypeScript based consuming applications

@vscav vscav added the enhancement New feature or request label Oct 9, 2023
@vscav vscav self-assigned this Oct 9, 2023
@vscav vscav force-pushed the addon-typescript-conversion branch from 1debf75 to d6ba497 Compare October 11, 2023 06:52
@vscav vscav marked this pull request as ready for review October 11, 2023 09:42
Copy link
Collaborator

@dannycalleri dannycalleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! 🚀

@vscav vscav merged commit dd0e0fb into master Oct 19, 2023
15 checks passed
@vscav vscav deleted the addon-typescript-conversion branch October 19, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants