Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pasting from clipboard values support #774

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

wandroll
Copy link
Contributor

@wandroll wandroll commented Mar 7, 2024

This MR aims at fixing this issue described here : #773

by providing better support for paste from clipboard:

  • it listen to the paste event
  • tries to parse values omitting the spaces

@wandroll wandroll linked an issue Mar 7, 2024 that may be closed by this pull request
@wandroll wandroll self-assigned this Mar 7, 2024
@wandroll wandroll requested a review from vscav March 7, 2024 16:13
@wandroll wandroll force-pushed the fixPastInputWithSpace branch 2 times, most recently from c92ba18 to 7a33c36 Compare March 7, 2024 16:17
@wandroll wandroll added the enhancement New feature or request label Mar 7, 2024
@wandroll wandroll changed the title Improve pasting from clipboard valeus support Improve pasting from clipboard values support Mar 7, 2024
@vscav
Copy link
Member

vscav commented Mar 8, 2024

Do you think we could remove the empty scope from the commit names? Like:

- test(): add a way to simulate paste event
+ test: add a way to simulate paste event
- feat(): handle pasted strings
+ feat: handle pasted strings

Copy link
Member

@vscav vscav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wandroll 🙏

@wandroll wandroll merged commit 8b4d478 into master Mar 8, 2024
17 checks passed
@wandroll wandroll deleted the fixPastInputWithSpace branch March 8, 2024 08:47
@wandroll wandroll linked an issue Mar 8, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better handle pasted value
3 participants