Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update action-setup-pnpm to v3 #202

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Conversation

nicolasgasco
Copy link
Contributor

The aim of this MR is using wyvox/action-setup-pnpm@v3 in place of NullVoxPopuli/action-setup-pnpm@v2 in our CI script.

NullVoxPopuli/action-setup-pnpm has been archived and moved to another repository.

@nicolasgasco nicolasgasco requested review from dannycalleri and vscav and removed request for dannycalleri and vscav September 19, 2023 08:19
Copy link
Contributor

@poulet42 poulet42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the no-lockfile option has been removed

@nicolasgasco
Copy link
Contributor Author

I think the no-lockfile option has been removed

It was @poulet42 , but it was already refactored to no-lockfile: true for this project some months ago

@nicolasgasco nicolasgasco merged commit 4b452c3 into main Sep 19, 2023
10 checks passed
@nicolasgasco nicolasgasco deleted the action-setup-pnpm-v3 branch September 19, 2023 09:35
@vscav vscav added the internal label Sep 19, 2023
@poulet42
Copy link
Contributor

I think the no-lockfile option has been removed

It was @poulet42 , but it was already refactored to no-lockfile: true for this project some months ago

@nicolasgasco Sorry I don't think I understood your reply 😄 , you can't use

with:
  no-lockfile: true

anymore with the new version of this action, you have to rewrite it as

with:
  args: --no-lockfile

@vscav vscav changed the title Update action-setup-pnpm to v3 chore: update action-setup-pnpm to v3 Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants