init

qonto · Dec 18, 2023 · f466ee5 · f466ee5
1 parent 53df6fd
commit f466ee5
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 20 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -13,16 +13,13 @@ linters:
   enable-all: false
   disable-all: false
   enable:
-    - deadcode
     - errcheck
     - gosimple
     - govet
     - ineffassign
     - staticcheck
-    - structcheck
     - typecheck
     - unused
-    - varcheck
     - asciicheck
     - bodyclose
     - dogsled
@@ -41,7 +38,6 @@ linters:
     - gomodguard
     - goprintffuncname
     - gosec
-    - ifshort
     - importas
     - makezero
     - misspell

diff --git a/internal/app/calculators/date_test.go b/internal/app/calculators/date_test.go
@@ -10,11 +10,11 @@ import (
 
 func TestDateCalculateObsolescenceScore(t *testing.T) {
 	testCases := []struct {
-		software      s.Software
+		software      *s.Software
 		expectedScore int
 	}{
 		{
-			software: s.Software{
+			software: &s.Software{
 				Version:           s.Version{ReleaseDate: time.Now()},
 				VersionCandidates: []s.Version{},
 				Dependencies: []*s.Software{
@@ -31,7 +31,7 @@ func TestDateCalculateObsolescenceScore(t *testing.T) {
 			expectedScore: 25,
 		},
 		{
-			software: s.Software{
+			software: &s.Software{
 				Version:           s.Version{ReleaseDate: time.Now()},
 				VersionCandidates: []s.Version{},
 				Dependencies: []*s.Software{
@@ -51,7 +51,7 @@ func TestDateCalculateObsolescenceScore(t *testing.T) {
 			expectedScore: 25,
 		},
 		{
-			software: s.Software{
+			software: &s.Software{
 				Version: s.Version{ReleaseDate: time.Now().Add(-73 * time.Hour)},
 				VersionCandidates: []s.Version{
 					{ReleaseDate: time.Now().Add(-23 * time.Hour)},
@@ -62,7 +62,7 @@ func TestDateCalculateObsolescenceScore(t *testing.T) {
 	}
 	calculator := New(zap.NewExample(), s.ReleaseDateCalculator, true)
 	for _, tc := range testCases {
-		err := calculator.CalculateObsolescenceScore(&tc.software)
+		err := calculator.CalculateObsolescenceScore(tc.software)
 		if err != nil {
 			t.Fatal(err)
 		}

diff --git a/internal/app/calculators/default_test.go b/internal/app/calculators/default_test.go
@@ -10,11 +10,11 @@ import (
 
 func TestCalculateObsolescenceScore(t *testing.T) {
 	testCases := []struct {
-		software      s.Software
+		software      *s.Software
 		expectedScore int
 	}{
 		{
-			software: s.Software{
+			software: &s.Software{
 				Name:              "no-deps-and-up-to-date",
 				Version:           s.Version{Version: "11.1.1"},
 				VersionCandidates: []s.Version{},
@@ -23,7 +23,7 @@ func TestCalculateObsolescenceScore(t *testing.T) {
 			expectedScore: 0,
 		},
 		{
-			software: s.Software{
+			software: &s.Software{
 				Name:              "deps and up-to-date",
 				Version:           s.Version{Version: "11.1.1"},
 				VersionCandidates: []s.Version{},
@@ -47,7 +47,7 @@ func TestCalculateObsolescenceScore(t *testing.T) {
 	for _, tc := range testCases {
 		fmt.Println(tc.software.Name)
 		calculator := New(zap.NewExample(), tc.software.Calculator, true)
-		err := calculator.CalculateObsolescenceScore(&tc.software)
+		err := calculator.CalculateObsolescenceScore(tc.software)
 		if err != nil {
 			t.Fatal(err)
 		}

diff --git a/internal/app/calculators/meta_test.go b/internal/app/calculators/meta_test.go
@@ -10,11 +10,11 @@ import (
 
 func TestMetaCalculateObsolescenceScore(t *testing.T) {
 	testCases := []struct {
-		software      s.Software
+		software      *s.Software
 		expectedScore int
 	}{
 		{
-			software: s.Software{
+			software: &s.Software{
 				Name:       "EKS-cluster-metacalculator",
 				Calculator: s.MetaCalculator,
 				Dependencies: []*s.Software{
@@ -38,7 +38,7 @@ func TestMetaCalculateObsolescenceScore(t *testing.T) {
 	for _, tc := range testCases {
 		fmt.Println(tc.software.Name)
 		calculator := New(zap.NewExample(), tc.software.Calculator, true)
-		err := calculator.CalculateObsolescenceScore(&tc.software)
+		err := calculator.CalculateObsolescenceScore(tc.software)
 		if err != nil {
 			t.Fatal(err)
 		}

diff --git a/internal/app/sources/aws/rds/source_test.go b/internal/app/sources/aws/rds/source_test.go
@@ -41,24 +41,24 @@ func TestLoad(t *testing.T) {
 	)
 
 	tcases := []struct {
-		cfg                   Config
+		cfg                   *Config
 		expectedSoftwareCount int
 	}{
 		{
-			cfg: Config{
+			cfg: &Config{
 				AggregationLevel: "cluster",
 			},
 			expectedSoftwareCount: 2,
 		},
 		{
-			cfg: Config{
+			cfg: &Config{
 				AggregationLevel: "instance",
 			},
 			expectedSoftwareCount: 3,
 		},
 	}
 	for _, tc := range tcases {
-		src, err := NewSource(api, zap.NewExample(), &tc.cfg)
+		src, err := NewSource(api, zap.NewExample(), tc.cfg)
 		if err != nil {
 			t.Error(err)
 		}