Fix Segfault with MSK new 3.7.x version candidates #7
+197
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Why AWS [changed their version naming convention on MSK](https://docs.aws.amazon.com/msk/latest/developerguide/supported-kafka-versions.html#3.7.kraft) leading to a new 3.7.x version candidate for upgrade (automatic patch update handled by AWS) This is generating Segfault in this application with the go-version/semver library not parsing it correctly. We fixed this issue updating MSK handler to replace those 'x' version part by a valid number. Because AWS is handling all patch version, replacing by `0` should produce the expected result we want on the upgrade manager service. ## How - Update MSK source version connector to handle semver containing 'x' - Update the semver Sort function to return proper error instead of crashing with segfault - The codebase already [expose a metric with the number of processingError](https://github.com/qonto/upgrade-manager/blob/main/internal/app/app.go#L281). Alert can be built on this metric to be notified of future version issue without having the application crashing and failing to produce report for all other monitored source Signed-off-by: Allan Jacquet-Cretides <allan.jacquet@qonto.com>
Jumanjii
force-pushed
the
fix-msk-dot-x-version-segfault
branch
from
9190def
to
021b303
Compare
Signed-off-by: Allan Jacquet-Cretides <allan.jacquet@qonto.com>
Jumanjii
force-pushed
the
fix-msk-dot-x-version-segfault
branch
from
b9f7caa
to
e1c3aa5
Compare
|
#sre |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
AWS changed their version naming convention on
MSK leading to a new 3.7.x version candidate for upgrade (automatic patch update handled by AWS)
This generates Segfault in this application with the go-version/semver library not parsing it correctly.
We fixed this issue by updating the MSK handler to replace those 'x' version parts with a valid number.
Because AWS is handling all patch versions, replacing it with
0should produce the expected result we want on the upgrade manager service.How