Conversation
Co-authors: Maciej Bacal <maciej.bacal.ext@qorix.ai>, Toma Ungureanu <TomaU_Ext.qorix.ai> Signed-off-by: Toma Ungureanu <TomaU_Ext@qorix.ai>
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
| enum class hm_Status : int | ||
| { | ||
| Running, | ||
| Disabled, | ||
| Failed, | ||
| }; | ||
|
|
||
| enum class hm_Error : int | ||
| { | ||
| NoError, | ||
| BadParameter, | ||
| DoesNotExist, | ||
| NotAllowed, | ||
| OutOfMemory, | ||
| Generic, | ||
| }; |
There was a problem hiding this comment.
| enum class hm_Status : int | |
| { | |
| Running, | |
| Disabled, | |
| Failed, | |
| }; | |
| enum class hm_Error : int | |
| { | |
| NoError, | |
| BadParameter, | |
| DoesNotExist, | |
| NotAllowed, | |
| OutOfMemory, | |
| Generic, | |
| }; | |
| enum class hm_Status : uint32_t | |
| { | |
| Running, | |
| Disabled, | |
| Failed, | |
| }; | |
| enum class hm_Error : uint32_t | |
| { | |
| NoError, | |
| BadParameter, | |
| DoesNotExist, | |
| NotAllowed, | |
| OutOfMemory, | |
| Generic, | |
| }; |
For consistency
| namespace hm | ||
| { | ||
|
|
||
| struct Deadline |
There was a problem hiding this comment.
| struct Deadline | |
| class Deadline |
| hm_Deadline *ptr; | ||
| }; | ||
|
|
||
| struct DeadlineMonitor |
There was a problem hiding this comment.
| struct DeadlineMonitor | |
| class DeadlineMonitor |
| @@ -0,0 +1,178 @@ | |||
| // Copyright (c) 2025 Contributors to the Eclipse Foundation | |||
There was a problem hiding this comment.
Please stick to one class per file. I expect something like:
deadline_monitor_ffi.hpp
deadline_monitor.hpp
deadline_monitor_builder.hpp
deadline.hpp
| } | ||
| } | ||
|
|
||
| pub fn status(&self) -> Status { |
There was a problem hiding this comment.
| pub fn status(&self) -> Status { | |
| pub(crate) fn status(&self) -> Status { |
| // SPDX-License-Identifier: Apache-2.0 | ||
| // | ||
| use crate::common::{Error, Status}; | ||
| use crate::common::{Error, Status, Tag, DurationRange}; |
There was a problem hiding this comment.
I would expect that in a final version, we should define builder, monitor, deadline and specific tests in separate files
TomaUngureanu
left a comment
TomaUngureanu
left a comment
There was a problem hiding this comment.
I would kindly ask you to rebase upon the Rust infra activation PR for the final folder structure: eclipse-score#24
Please let me know if a deadline module is feasible (monitor.rs, builder.rs, deadline.rs etc)
2 participants
No description provided.