1716 Generalize syntax of arrow expressions #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelhkay
added
XPath
ChristianGruen
approved these changes
Feb 3, 2025
ChristianGruen
added
the
Propose Merge without Discussion
michaelhkay
removed
the
Propose Merge without Discussion
|
I dropped the "merge without discussion" label because I'd like to encourage people to review it carefully. |
michaelhkay
force-pushed
the
1716-simplify-arrow-target
branch
from
c2252a3 to
4dbd9ac
Compare
| <note><p>The expression <code>U => $V(X)(Y)</code> satisfies the grammar, but its meaning | ||
| might not be obvious. It is interpreted as being equivalent to <code>$V(X)(U, Y)</code>. | ||
| The same applies to the mapping arrow operator: <code>U =!> $V(X)(Y)</code> is | ||
| interpreted as <code>for $u in $V return $V(X)($u, Y)</code>. This follows from |
There was a problem hiding this comment.
"for $u in $V" should be "for $u in $U"
michaelhkay
force-pushed
the
1716-simplify-arrow-target
branch
from
4dbd9ac to
c4e10a4
Compare
michaelhkay
added
Tests Added
This was referenced Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1716