Add CI workflows by copy/pasting the meta-qcom ones#118
Add CI workflows by copy/pasting the meta-qcom ones#118koenkooi wants to merge 18 commits intoqualcomm-linux:mainfrom
Conversation
|
Marking this as draft since:
|
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| repository: qualcomm-linux/meta-qcom |
There was a problem hiding this comment.
don't you need to say master here? or is it the default? perhaps better to say it though, so that we have less chances to make a mistake when we branch for LTS!
There was a problem hiding this comment.
Should the branch name be extracted as a param? We can do that later, of course. Or maybe we should use GITHUB_BASE_REF / GITHUB_REF here.
045be35 to
05d76d7
Compare
|
Since the nuts and bolts of this seem to be working, do we want to change the list of machines and images this builds? |
| cache_dir: ${CACHE_DIR} | ||
| kas: ${KAS_CONTAINER} | ||
|
|
||
| publish_summary: |
There was a problem hiding this comment.
not for this PR, but we need to figure out how not to duplicate this one, and turn it into a reusable action. can you make a note for it?
| @@ -0,0 +1,31 @@ | |||
| name: Build on push | |||
There was a problem hiding this comment.
please update README to show the status of HEAD.
There was a problem hiding this comment.
Done, not sure how to check that.
05d76d7 to
bebcd02
Compare
|
|
||
| on: | ||
| workflow_run: | ||
| workflows: ["Build on PR"] |
There was a problem hiding this comment.
the test-pr did not run in your branch. probably because it needs to be merged in master to get the event.. not blocking, but we will need to make sure tests are run when we merge.
7d97ae2 to
0f808fd
Compare
0f808fd to
94c5daf
Compare
lumag
left a comment
There was a problem hiding this comment.
I somewhat dislike the dropping of the build matrix change. It makes this CI to be a downstream of the meta-qcom one. In my opinion, we should be doing exactly the opposite: the meta-qcom should be validated against poky-altcfg (possibly +meta-oe), while this repo should validate the final product: meta-qcom, all our meta-layer-dependencies, etc.
Think about meta-virt breaking one of the recipes. With the proposed workflow it will still affect our meta-qcom builds (which it should not). Instead, meta-virt (again, pure example) issues should only be affecting meta-qcom-distro builds.
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| repository: qualcomm-linux/meta-qcom |
There was a problem hiding this comment.
Should the branch name be extracted as a param? We can do that later, of course. Or maybe we should use GITHUB_BASE_REF / GITHUB_REF here.
I appreciate your comment and share most of it. However we've been procrastinating about meta-qcom-distro CI for months now, and nothing was merged. This PR , as mentioned in the initial log, is to 'get CI going'. We can (and will) optimize/rework the meta-qcom/meta-qcom-distro workflows once we have an initial CI in place (note that we need to think about meta-qcom-3rdparty too). would that work? |
I'd prefer to keep the full matrix here, inside meta-qcom-distro and then drop all meta-qcom-distro jobs from meta-qcom layer. |
me too. but:
|
I think, it is a proper thing to do. I would propose to enable full matrix of builds here (as a way to end up procrastination too). Then we can start pointing out people to meta-qcom-distro builds, etc. |
Yeah, let's duplicate the matrix here and work on moving people to start fetching the jobs (and related testing / lava changes) from this repo instead. We can have the duplicated CI for a few weeks, decide on a date and remove the extra CI from meta-qcom. We had quite a few build failures over the past few weeks that are really qcom-distro related, so it is good to reduce the CI complexity from meta-qcom soon. |
|
The |
This repo needs CI, as a first step copy over the workflow from qualcomm-linux/meta-com.git with the folllowing changes: * Change repository name checks to repo owner checks This should be propagated to all repos using this style of workflows to make sharing of the same code snippets easier. * Change 'meta-qcom' to 'meta-qcom-distro' where approriate And the reverse, specify 'meta-qcom' where things like KAS config files are referenced. * Reuse 'compile' action from meta-qcom.git instead of duplicating it The KAS configuration files and CI helper scripts present in meta-qcom.git/ci/ are being pulled from there for each CI run, they are not being copied or modified. Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com>
The CI only needs to test if the DISTROs work, not the BSPs itself, so restrict the build to the following 3 machines: * qcom-armv7a * qcom-armv8a * rb3gen2-core-kit Restrict the KVM build to qcom-armv8a, it is not supported on armv7a machines. As a consequence: drop the warmup task, it isn't needed with the much reduced scope. Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com>
Since we share sstate with meta-qcom, the monthly reaper covers us as well, so drop it from here. Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com>
The CI build here is a subset of meta-qcom.git, so this can be dropped. Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com>
Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com>
…per repo Checkout meta-qcom-distro and run the layer and patch checker helpers against that, not meta-qcom.git. Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com>
Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com>
Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com>
…eta-qcom CI Meta-qcom-distro CI should test all the combinations it supports and not depend on CI from other reps like meta-qcom to accomplish this. Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com>
Removing the 'compile_warmpup' step also removed the dependencies the compile step needs. Reinstated those. Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com>
…m and explicity chdir into it Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com>
Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com>
…cto-lts KAS configs Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com>
This now hardcodes 'meta-qcom-distro' and removes the BSP checks, since this isn't a BSP layer. Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com>
Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com>
Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com>
Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com>
dc7275c to
a255e43
Compare
Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com>
|
As we discussed on slack, closing this one in favor of #139 |
To get CI going on meta-qcom-distro, copy over the meta-qcom workflows with minimal changes.
The changes are: