recipes-products/images/qcom-minimal-image: Add rt-tests and stress-ng by DeewanS · Pull Request #160 · qualcomm-linux/meta-qcom-distro

DeewanS · 2026-02-11T19:06:09Z

Add rt-tests and stress-ng to package list (for linux-qcom-rt kernel)

ricardosalveti · 2026-02-11T20:44:55Z

recipes-products/images/qcom-minimal-image.bb

 TOOLCHAIN_TARGET_TASK += "kernel-devsrc"
+
+# Add RT tools only if the RT kernel is selected
+IMAGE_INSTALL:append = "${@bb.utils.contains('PREFERRED_PROVIDER_virtual/kernel', 'linux-qcom-rt', ' rt-tests stress-ng', '', d)}"


Please explain why you are adding rt-tests and stress-ng as part of your commit message.

Also, why qcom-minimal-image?

stress-ng is also useful without the rt kernel, so should just go as an utility (e.g. recipes-products/packagegroups/packagegroup-qcom-utilities.bb).

Thanks for the review!
Updated as suggested:

Moved stress-ng into packagegroup-qcom-utilities (profile-utils subpackage) so it’s available as a general validation tool and not tied to RT.
Expanded the commit message to explain the rationale (no RT-specific distro in this layer, and any image can enable RT by selecting the RT kernel provider).

Please take another look.

recipes-products/images/qcom-minimal-image.bb

lumag · 2026-02-13T14:06:35Z

recipes-products/images/qcom-minimal-image.bb

 # Default root password: oelinux123
 EXTRA_USERS_PARAMS = "usermod -p '\$6\$UDMimfYF\$akpHo9mLD4z0vQyKzYxYbsdYxnpUD7B7rHskq1E3zXK8ygxzq719wMxI78i0TIIE0NB1jUToeeFzWXVpBBjR8.' root;"

 # Adding kernel-devsrc to provide kernel development support on SDK


image: add rt-tests when using linux-qcom-rt kernel

Which image? You are touching one recipe.

Thanks, good point. I’ve updated the commit message to explicitly reference the qcom-minimal-image.bb recipe instead of using the generic term “image”. Please take another look.

lumag · 2026-02-13T14:07:00Z

recipes-products/packagegroups/packagegroup-qcom-utilities.bb

    sysbench \
    systemd-analyze \
    tiobench \
+    stress-ng \


Keep the list sorted

Updated - the package list is now alphabetically sorted as suggested.

lumag · 2026-02-13T14:07:26Z

recipes-products/packagegroups/packagegroup-qcom-utilities.bb

 RDEPENDS:${PN}-profile-utils = " \
    perf \
    powertop \
    sysbench \


stress-ng is a ...
add it to...

Sentences should start with the capital letter.

Thanks for pointing that out. I’ve fixed the commit message wording, ensured sentences start with capital letters

vkraleti · 2026-02-13T14:53:14Z

recipes-products/images/qcom-minimal-image.bb

 TOOLCHAIN_TARGET_TASK += "kernel-devsrc"
+
+# Add RT tools only if the RT kernel is selected
+IMAGE_INSTALL:append = "${@bb.utils.contains('PREFERRED_PROVIDER_virtual/kernel', 'linux-qcom-rt', ' rt-tests', '', d)}"


How about "linux-qcom-next-rt" Kernel?

Thanks! Updated to also handle linux-qcom-next-rt. Switched the conditional accordingly.

quaresmajose · 2026-02-16T19:06:25Z

recipes-products/images/qcom-minimal-image.bb

 TOOLCHAIN_TARGET_TASK += "kernel-devsrc"
+
+# Add RT tools only if the RT kernel is selected
+IMAGE_INSTALL:append = "${@bb.utils.contains_any('PREFERRED_PROVIDER_virtual/kernel', \


What the reason to not use the CORE_IMAGE_BASE_INSTALL?

Thanks for the question.

I kept this out of CORE_IMAGE_BASE_INSTALL because I intended that variable to remain limited to packages essential for system boot and core functionality.

Since rt-tests is a validation suite specific to PREEMPT_RT rather than a runtime requirement, placing it under IMAGE_INSTALL keeps the separation clear between core system components and optional tools.

If you have a specific reason for preferring the base install list, I’m happy to revisit it.

IMAGE_INSTALL should not be called directly. As we are using the meta/classes-recipe/core-image.bbclass, we should use CORE_IMAGE_BASE_INSTALL or CORE_IMAGE_EXTRA_INSTALL which are defined in this class. So please use the CORE_IMAGE_EXTRA_INSTALL in this case.

Thanks for the feedback. I've updated the recipe to use CORE_IMAGE_EXTRA_INSTALL instead of appending to IMAGE_INSTALL.

quaresmajose · 2026-02-17T12:37:14Z

recipes-products/images/qcom-minimal-image.bb

 TOOLCHAIN_TARGET_TASK += "kernel-devsrc"
+
+# Add RT tools only if the RT kernel is selected
+CORE_IMAGE_EXTRA_INSTALL:append = "${@bb.utils.contains_any('PREFERRED_PROVIDER_virtual/kernel', \


please also use the += instaed of the :append

Updated — replaced the :append with += as requested.
Thanks.

…-next-rt Install rt-tests only when PREEMPT_RT is selected using: PREFERRED_PROVIDER_virtual/kernel = linux-qcom-rt or linux-qcom-next-rt. This ensures rt-tests is included only for RT-enabled builds as rt-tests is specific to validating PREEMPT_RT behavior(cyclictest, signaltest, hwlatdetect, etc.) Added rt-tests in qcom-minimal-image as any QCOM image can opt for RT kernel, and qcom-minimal-image is included in all images. Signed-off-by: Deewan Singh <deewsing@qti.qualcomm.com>

Stress-ng is a general-purpose system stress tool useful for platform validation across kernels (CPU/mem/I/O/thermal, etc.). Add it to the utilities packagegroup (profile-utils) so images that already consume profiling utilities will include it. Signed-off-by: Deewan Singh <deewsing@qti.qualcomm.com>

akdwived-dev · 2026-02-17T21:51:54Z

@lumag @quaresmajose @ricardosalveti @vkraleti let us know if any more comment else help approve changes.

DeewanS requested review from lumag, ndechesne, ricardosalveti, sbanerjee-quic and vkraleti as code owners February 11, 2026 19:06

ricardosalveti reviewed Feb 11, 2026

View reviewed changes

DeewanS force-pushed the topic/add-stress-test-tools branch from 834cc98 to 9f6ff70 Compare February 12, 2026 04:05

lumag requested changes Feb 13, 2026

View reviewed changes

recipes-products/images/qcom-minimal-image.bb Outdated Show resolved Hide resolved

DeewanS force-pushed the topic/add-stress-test-tools branch from 9f6ff70 to 7a777d3 Compare February 13, 2026 06:39

DeewanS requested a review from lumag February 13, 2026 06:55

lumag requested changes Feb 13, 2026

View reviewed changes

DeewanS force-pushed the topic/add-stress-test-tools branch from 7a777d3 to 8a08e84 Compare February 13, 2026 14:38

DeewanS requested a review from lumag February 13, 2026 14:41

vkraleti reviewed Feb 13, 2026

View reviewed changes

DeewanS force-pushed the topic/add-stress-test-tools branch from 8a08e84 to c999621 Compare February 14, 2026 13:21

quaresmajose reviewed Feb 16, 2026

View reviewed changes

DeewanS force-pushed the topic/add-stress-test-tools branch from c999621 to 658f00a Compare February 17, 2026 12:15

quaresmajose reviewed Feb 17, 2026

View reviewed changes

DeewanS force-pushed the topic/add-stress-test-tools branch 2 times, most recently from 81210ac to 704053b Compare February 17, 2026 13:53

quaresmajose approved these changes Feb 17, 2026

View reviewed changes

lumag approved these changes Feb 17, 2026

View reviewed changes

koenkooi approved these changes Feb 18, 2026

View reviewed changes

vkraleti merged commit e1627ec into qualcomm-linux:main Feb 18, 2026
2 checks passed

Conversation

DeewanS commented Feb 11, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akdwived-dev commented Feb 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants