linux: Add support to build kernel from local path#225
linux: Add support to build kernel from local path#225vishwasudupa wants to merge 1 commit intoqualcomm-linux:mainfrom
Conversation
optionally --kernel-src-path argument can be used to compile kernel from local path Signed-off-by: Vishwas Udupa <vudupa@qti.qualcomm.com>
|
Hey @vishwasudupa, sorry I am just seeing your PR now, I missed it when you submitted it (feel free to ping maintainers if a PR lingers for a while); starting a review |
lool
left a comment
lool
left a comment
There was a problem hiding this comment.
Generally looks good, if you could just tweak the flag name and help text, I think we're good
There was this also this linting failure, you need to wrap long lines:
https://github.com/qualcomm-linux/qcom-deb-images/actions/runs/21472670921/job/61848844844?pr=225
| help="Use qcom-next repository and ref defaults", | ||
| ) | ||
| parser.add_argument( | ||
| "--kernel-src-path", |
There was a problem hiding this comment.
perhaps a bit verbose, how about --src, --source, or --local-dir? It looks like you had this as src-path before
| if args.kernel_src_path: | ||
| src_path = Path(args.kernel_src_path) | ||
| if not src_path.exists(): | ||
| fatal(f"Provided --src-path '{src_path}' does not exist") |
There was a problem hiding this comment.
this still says --src-path instead of --kernel-src-path
|
FYI, I'm also trying to land #229 which might conflict, sorry about that |
|
Hello @vishwasudupa, I can take over this PR and rebase it + apply the suggested changes if this sounds fine to you. I happen to need to compile and patch local kernels so this would be a nice to have. |
3 participants
optionally --kernel-src-path argument can be used to compile kernel from local path