IRIS Video: stabilize stack switching & avoid duplicate heavy ops in --stack both, cleaner logs and safer Kodiak FW flow#182
Merged
abbajaj806 merged 1 commit intoqualcomm-linux:mainfrom Oct 7, 2025
Conversation
smuppand
changed the title
smuppand
force-pushed
the
video-fix
branch
2 times, most recently
from
bdb37ff to
eb3179c
Compare
…y guards for rootfs check, early bundle fetch, FW ops. - Prevent duplicate rmmod/modprobe cycles and reduce kernel panic risk. - Harden modprobe/insmod with retries and persistent de-blacklist. - Kodiak: install upstream FW on base; apply downstream FW override once. - Preserve pre/post stack dumps and V4L node refresh; better dmesg hints. - lib_video.sh: robust clip discovery/fetch and ensure app executable. - run.sh/functestlib.sh/YAML: expose tunables and idempotent downloads. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces top-level vs sub-run gating in run.sh so heavy operations run once per --stack both execution:
Adds robust post-stack capture in run.sh:
Keeps Kodiak firmware handling safe and minimal:
upstream FW install done once per pass
downstream reload only when requested/needed, with existing lib_video.sh helpers
Preserves CLI and logic; no renames, no one-liners. Logging now explicitly states when sub-runs skip costly steps (e.g., “Sub-run: skipping rootfs size check”).
lib_video.sh enhancements leveraged:
retrying modprobe, runtime block/unblock, persistent blacklist handling, V4L node refresh, FW swap/reload helpers
functestlib.sh & YAML: no interface changes; existing helpers (check_dependencies, extract_tar_from_url, ensure_rootfs_min_size, scan_dmesg_errors) used as-is.
Verification
Compatibility & Risk