Add individual test definitions by mwasilew · Pull Request #207 · qualcomm-linux/qcom-linux-testkit

mwasilew · 2025-11-03T18:50:07Z

Individual test definitions are meant to be used for debugging the test scripts running in LAVA.

smuppand

LGTM apart from the typo

smuppand · 2025-12-04T10:41:36Z

Runner/suites/Connectivity/Bluetooth/BT_SCAN_PAIR/BT_SCAN_PAIR.yaml

+  scope:
+    - functional
+
+parames:


likely typo instead of params

good catch. Thanks!

mwasilew · 2025-12-04T10:48:41Z

I split the big commit into smaller chunks that address individual issues. It's ready for review now

smuppand · 2025-12-04T15:34:58Z

Runner/suites/Kernel/Baseport/RMNET/run.sh

+    log_info "Writing to file $RES_FILE"
+    echo "$TESTNAME PASS" >"$RES_FILE"
+else
+    log_fail "$TESTNAME PASS"


We should display as FAIL.

smuppand · 2025-12-04T16:42:23Z

Runner/suites/Kernel/Baseport/IPA/run.sh

-    [ -n "$MODPATH" ] || log_fail "$MODNAME.ko not found in filesystem"
-    load_kernel_module "$MODPATH" || log_fail "Failed to load $MODNAME"
+    [ -n "$MODPATH" ] || (log_fail "$MODNAME.ko not found in filesystem"; echo "$TESTNAME FAIL" >"$RES_FILE")
+    load_kernel_module "$MODPATH" || (log_fail "Failed to load $MODNAME"; echo "$TESTNAME FAIL" >"$RES_FILE")


possible for us to keep multiple lines?

do you mean to reformat subshell?

smuppand · 2025-12-04T17:33:54Z

@mwasilew Does Lava YAML follow any strict linting rules?

mwasilew · 2025-12-05T09:29:16Z

@mwasilew Does Lava YAML follow any strict linting rules?

yes, kind of. There is no enforcement in LAVA itself. In test-definitions there is this script: https://github.com/Linaro/test-definitions/blob/master/validate.py#L96. It's probably a bit too strict for the test definitions in this repository. I can add something similar if you would like.

smuppand · 2025-12-05T09:56:39Z

@mwasilew Does Lava YAML follow any strict linting rules?

yes, kind of. There is no enforcement in LAVA itself. In test-definitions there is this script: https://github.com/Linaro/test-definitions/blob/master/validate.py#L96. It's probably a bit too strict for the test definitions in this repository. I can add something similar if you would like.

Thanks. Yes, it may be needed once this PR is merged. At least having the basic structure that the lava test-definition expects would be a good sanity check.

mwasilew · 2025-12-05T09:58:18Z

OK, I'll propose a test-definition check workflow in a separate PR.

smuppand

There are a few minor updates to the video yaml.

smuppand · 2025-12-05T10:15:14Z

Runner/suites/Multimedia/Video/Video_V4L2_Runner/Video_V4L2_Runner.yaml

+
+params:
+  APP_PATH: "/usr/bin/iris_v4l2_test"
+  CONFIG_PATH: "./h264Decoder.json"


CONFIG_PATH can refer to CWD, and the script will process all *.json files within it.

ah, so if I leave it with "./" it will run use all JSON files?

ah, so if I leave it with "./" it will run use all JSON files?

Yes, this should be fine.

smuppand · 2025-12-05T10:18:17Z

Runner/suites/Multimedia/Video/Video_V4L2_Runner/Video_V4L2_Runner.yaml

+params:
+  APP_PATH: "/usr/bin/iris_v4l2_test"
+  CONFIG_PATH: "./h264Decoder.json"
+  PLATFORM: "kodiak"


This field can remain blank since we automatically detect the platform and apply the required configurations. Otherwise, the target name must be provided from the lava job.

ACK. I'll leave it blank and add the comments to explain.

ACK. I'll leave it blank and add the comments to explain.

Yes, this should be fine.

When saving LAVA results logfile is sometimes in a wrong path. This patch adds more logging to make sure results are written to the proper file. Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>

Print debug log to stdout. This helps debugging issues when running tests in LAVA as the debug log is saved to the LAVA job log. Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>

Save test result to the log file in case module is not found. This condition was missing when running the test in LAVA. Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>

Save test result to the results file that is later exported in a LAVA job. This feature was missing and when running a job in LAVA no results were recorded. Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>

Add a test-definitions YAML file for each test script. This allows to compose more flexible test plans and test each script separately in LAVA. Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>

mwasilew · 2025-12-08T13:37:47Z

I rebased on top of main branch

smuppand

LGTM

mwasilew changed the title ~~Add individual test definitions~~ WIP: Add individual test definitions Nov 3, 2025

mwasilew force-pushed the individual-test-definitions branch from 9b6f269 to c712c5c Compare November 28, 2025 13:24

mwasilew mentioned this pull request Nov 28, 2025

Added individual testplans for Kernel suites #211

Closed

mwasilew force-pushed the individual-test-definitions branch 27 times, most recently from c967ff6 to 409519b Compare December 1, 2025 09:32

mwasilew force-pushed the individual-test-definitions branch 3 times, most recently from 5eccc0f to cad2f3e Compare December 1, 2025 20:03

smuppand requested changes Dec 4, 2025

View reviewed changes

mwasilew force-pushed the individual-test-definitions branch from cad2f3e to 9bb35a6 Compare December 4, 2025 10:45

mwasilew changed the title ~~WIP: Add individual test definitions~~ Add individual test definitions Dec 4, 2025

mwasilew force-pushed the individual-test-definitions branch from 9bb35a6 to bef7ce8 Compare December 4, 2025 10:47

smuppand requested changes Dec 4, 2025

View reviewed changes

mwasilew force-pushed the individual-test-definitions branch from bef7ce8 to 50794b4 Compare December 5, 2025 09:27

smuppand requested changes Dec 5, 2025

View reviewed changes

mwasilew force-pushed the individual-test-definitions branch from 50794b4 to 7902117 Compare December 5, 2025 11:43

mwasilew added 5 commits December 8, 2025 13:36

Add more logging when saving LAVA results

2e44fdd

When saving LAVA results logfile is sometimes in a wrong path. This patch adds more logging to make sure results are written to the proper file. Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>

KMSCube: show debug log in stdout

f6521f6

Print debug log to stdout. This helps debugging issues when running tests in LAVA as the debug log is saved to the LAVA job log. Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>

IPA: fail test when module is not found

50f36e8

Save test result to the log file in case module is not found. This condition was missing when running the test in LAVA. Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>

RMNET: Save test result to file for LAVA logging

7a30f38

Save test result to the results file that is later exported in a LAVA job. This feature was missing and when running a job in LAVA no results were recorded. Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>

Add individual test definitions

65db227

Add a test-definitions YAML file for each test script. This allows to compose more flexible test plans and test each script separately in LAVA. Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>

mwasilew force-pushed the individual-test-definitions branch from 7902117 to 65db227 Compare December 8, 2025 13:37

smuppand approved these changes Dec 9, 2025

View reviewed changes

smuppand merged commit e0c5e1b into qualcomm-linux:main Dec 9, 2025
8 checks passed

smuppand mentioned this pull request Dec 9, 2025

Add YAML configuration for qcom_hwrng test scripts to support the LAVA framework #225

Closed

Conversation

mwasilew commented Nov 3, 2025

Uh oh!

smuppand left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mwasilew commented Dec 4, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

smuppand commented Dec 4, 2025

Uh oh!

mwasilew commented Dec 5, 2025

Uh oh!

smuppand commented Dec 5, 2025

Uh oh!

mwasilew commented Dec 5, 2025

Uh oh!

smuppand left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mwasilew commented Dec 8, 2025

Uh oh!

smuppand left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments