Skip to content

Comments

Probe_Failure_Check: improve probe timeout & deferred device detection#219

Merged
vnarapar merged 1 commit intoqualcomm-linux:mainfrom
smuppand:probe-failure
Dec 17, 2025
Merged

Probe_Failure_Check: improve probe timeout & deferred device detection#219
vnarapar merged 1 commit intoqualcomm-linux:mainfrom
smuppand:probe-failure

Conversation

@smuppand
Copy link
Contributor

Summary

Tighten Probe_Failure_Check/run.sh so CI can catch more realistic probe
and firmware-related issues and provide better debug hints.

Key changes

  • Extend FAIL_PATTERN to match:
    • "deferred probe timeout, ignoring dependency"
    • "probe with driver failed with error …"
    • while keeping all existing probe/firmware/bind failure patterns.
  • Capture a fresh kernel log snapshot and:
    • Write all matching lines into probe_failures.log.
    • Emit up to 10 CI-HINT lines to stdout for quick triage.
  • If present, read /sys/kernel/debug/devices_deferred and:
    • Append unresolved deferred devices into probe_failures.log.
    • Emit DEFERRED: lines for unresolved deferred probes.
  • Keep script POSIX-sh and aligned with functestlib logging and
    $TESTNAME.res PASS/FAIL conventions.

Impact

  • CI will now flag SMMU-style probe timeouts and similar failures.
  • Developers get enough context in the CI log to debug without
    manually pulling dmesg from the DUT.

@smuppand smuppand requested a review from vnarapar November 25, 2025 05:25
Improve Probe_Failure_Check/run.sh to catch more realistic probe/firmware
issues in CI/CD:

- Extend FAIL_PATTERN to match:
  - "deferred probe timeout, ignoring dependency"
  - "probe with driver <drv> failed ..."
  while keeping all existing probe/firmware/bind patterns.
- Capture a kernel log snapshot and emit up to 10 representative
  CI-HINT lines to stdout/stderr for easier debugging.
- If available, read /sys/kernel/debug/devices_deferred and:
  - Log entries into probe_failures.log
  - Emit DEFERRED: lines for unresolved deferred probes.

Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Copy link
Contributor

@vnarapar vnarapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vnarapar vnarapar merged commit 5d57b46 into qualcomm-linux:main Dec 17, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants