Ethernet: Added force link speed on eth interface via ethtool#222
Closed
vnarapar wants to merge 1 commit intoqualcomm-linux:mainfrom
Closed
Ethernet: Added force link speed on eth interface via ethtool#222vnarapar wants to merge 1 commit intoqualcomm-linux:mainfrom
vnarapar wants to merge 1 commit intoqualcomm-linux:mainfrom
Conversation
Contributor
vnarapar
commented
Dec 3, 2025
vnarapar
commented
- Add --interface/-i and --speed/-s options
- Default link speed to 1000 Mbps when no speed is provided
- Force link speed on eth interface via ethtool
- Update README to document new CLI
smuppand
requested changes
Dec 3, 2025
| shift 2 | ||
| ;; | ||
| *) | ||
|
|
Contributor
There was a problem hiding this comment.
Better to add log_warn for unknown args
vnarapar
force-pushed
the
Ethernet_fix
branch
2 times, most recently
from
6601b16 to
10d5312
Compare
- Add --interface/-i and --speed/-s options - Default link speed to 1000 Mbps when no speed is provided - Force link speed on eth interface via ethtool - Update README to document new CLI Signed-off-by: Vamsee Narapareddi <vnarapar@qti.qualcomm.com>
vnarapar
force-pushed
the
Ethernet_fix
branch
from
10d5312 to
6af1dfe
Compare
smuppand
requested changes
Dec 17, 2025
| log_info "---- Testing interface: $iface ----" | ||
| model=$(get_machine_model) | ||
|
|
||
| if [ "$model" = "Monaco EVK" ] || [ "$model" = "Lemans EVK" ] || [ "$model" = "Lemans Ride Rev3" ] || [ "$model" = "QCS8300 Ride" ] || [ "$model" = "Robotics RB3gen2" ]; then |
Contributor
There was a problem hiding this comment.
Can this be made more generic instead of being specific to SoC?
| user_iface="$2" | ||
| shift 2 | ||
| ;; | ||
| --speed|-s) |
Contributor
There was a problem hiding this comment.
I'm considering how a user would know which port speed to provide. Wouldn't it be better to fetch the information from ethtool and set the speed based on the model, instead of letting the user choose?
Contributor
|
@vnarapar Would you like to close this PR? |
Contributor
Author
|
PR#235 will address it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.