Fix weston-simple-egl flakiness on fresh flash by improving Wayland/Weston bring-up and 60Hz enforcement#230
Merged
abbajaj806 merged 3 commits intoqualcomm-linux:mainfrom Dec 18, 2025
Conversation
… and reruns Autodetect Wayland socket and adopt XDG_RUNTIME_DIR/WAYLAND_DISPLAY reliably Add display + modetest + Wayland/Weston debug snapshots for CI visibility Run weston-simple-egl with timeout, capture logs, and parse FPS stats Enforce PASS/FAIL/SKIP semantics with optional FPS gating Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
…0@60 Avoid restarting Weston when it is not running (improves first-run stability) Restart Weston only when needed to apply weston.ini updates Harden weston process detection and silence ShellCheck SC2009 where required Keep changes non-fatal: mode enforcement remains best-effort for CI Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
…env adoption Add/strengthen weston_is_running and connection probe utilities Ensure XDG_RUNTIME_DIR creation/permissions handling for private Weston sessions Standardize restart/start flows via weston_pick_env_or_start / overlay start helpers Improve logging and resilience for CI runs without introducing new bashisms Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
smuppand
requested review from
Vkenjam,
abbajaj806,
bhargav0610 and
manasab-qli
abbajaj806
requested changes
Dec 18, 2025
| # Also enforces/fixes XDG_RUNTIME_DIR permissions so clients won’t reject it. | ||
| wayland_connection_ok() { | ||
| sock="" | ||
|
|
Contributor
There was a problem hiding this comment.
Can display specific function be moved to lib_display.sh
Contributor
Author
There was a problem hiding this comment.
There are several display/weston functions in the current functestlib.sh, and moving all of them to lib_display can be handled in a separate PR rather than in this one.
| # Best-effort: return current mode for a DRM connector using debugfs state. | ||
| # Input : full connector name like "card0-HDMI-A-1" | ||
| # Output: "1920x1080@60.00" (or "1920x1080@60") or "-" if unknown/unavailable | ||
| display_connector_cur_mode() { |
Contributor
There was a problem hiding this comment.
Same for this as well. Can this function be moved to lib_display.sh
| # Sysfs connectors (expects display_list_connectors to print tab-separated fields) | ||
| have=0 | ||
| while IFS="$(printf '\t')" read -r name status typ mc fm; do | ||
| while IFS="$(printf '\t')" read -r name status enabled typ mc fm cur; do |
Contributor
There was a problem hiding this comment.
Same for this as well. Can this function be moved to lib_display.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the weston-simple-egl test reliable across freshly flashed images and reruns by hardening Wayland session discovery and Weston start/stop behavior.