Standardize AudioRecord to use --record-seconds parameter#238
Merged
smuppand merged 1 commit intoqualcomm-linux:mainfrom Dec 22, 2025
Merged
Standardize AudioRecord to use --record-seconds parameter#238smuppand merged 1 commit intoqualcomm-linux:mainfrom
smuppand merged 1 commit intoqualcomm-linux:mainfrom
Conversation
Fixes qualcomm-linux#233 - Removed --rec-secs alias, standardized on --record-seconds - Updated internal variable from REC_SECS to RECORD_SECONDS - Updated usage() function to show --record-seconds - Updated --strict to show it accepts optional values [0|1] - Updated README documentation for consistency All documentation and code now consistently use --record-seconds. Signed-off-by: Teja Swaroop Moida <tmoida@qti.qualcomm.com>
smuppand
requested changes
Dec 22, 2025
Contributor
smuppand
left a comment
smuppand
left a comment
There was a problem hiding this comment.
Whenever you update the CLI parameter, please also verify the LAVA parameter and make sure the changes are reflected in the YAML file.
Contributor
Author
|
Yes, this is already addressed. The YAML file correctly uses "--record-seconds" parameter which matches the CLI parameter in run.sh. The LAVA parameter "RECORD_SECONDS" is properly mapped to the "--record-seconds" CLI option. |
Contributor
|
Thanks! I thought updating the README was an easier fix, but that works as well :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #233
All documentation and code now consistently use --record-seconds.