platforms: klmt: zero partitions without flashable content#49
Open
ricardosalveti wants to merge 1 commit intoqualcomm-linux:mainfrom
Open
platforms: klmt: zero partitions without flashable content#49ricardosalveti wants to merge 1 commit intoqualcomm-linux:mainfrom
ricardosalveti wants to merge 1 commit intoqualcomm-linux:mainfrom
Conversation
ricardosalveti
requested review from
lumag,
ndechesne,
sbanerjee-quic and
vkraleti
as code owners
Contributor
Author
|
Tested on rb3gen2, qcs9100-ride-sx and qcs615-adp-air, no clear side effect. Needs more testing as we could see unexpected errors. @mwasilew this should help getting the devices to a reproducible state, just not erasing ddr (and persist, but it is not yet used) because it implies in a new ddr training on every flash. |
Only ddr_a/b (ddr training) and persist remains without being zeroed on a clean flash, required in order to be able to always reproduce the same flash state on clean flash. Signed-off-by: Ricardo Salveti <ricardo.salveti@oss.qualcomm.com>
Contributor
|
My major concern with this is that all of the following partitions types are now very hard to distinguish:
|
Contributor
Author
|
Yup, even identifying the ones we don't need is not easy atm, ideally we should have a clear understanding of each of the individual partitions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only ddr_a/b (ddr training) and persist remains without being zeroed on a clean flash, required in order to be able to always reproduce the same flash state on clean flash.