Open
Conversation
Contributor
|
Hi @tnidigan, the build is failing with this patch. Can you check the issues |
tnidigan
force-pushed
the
urm-memory-reduction
branch
from
657d866 to
4c6b6a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request Implements Visibility Reduction for libRestuneCore.so to optimize memory usage. By compiling with hidden visibility by default and only exporting the necessary Public API and required internal helpers, we reduce the size of the Dynamic Symbol Table (.dynsym) and decrease runtime relocations.
Changes Implemented:
Build System: Added -fvisibility=hidden to target_compile_options in CMakeLists.txt for the RestuneCore target.
Public API: Explicitly exported the main URM entry points (e.g., Restune_Init, Restune_Deinit) using attribute((visibility("default"))).
Cross-Boundary Helpers: Exported necessary internal Singleton classes (e.g., TargetRegistry, ResourceRegistry) and helper functions (e.g., submitPropGetRequest, PulseMonitor daemons) that are defined in the library but required by the urm executable.