Change So That Tinyxml2 Is Integrated Using Git Submodule #67
+8
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted relevant 'CMakeLists.txt' files accordingly.
MrCeliaki
reviewed
Jan 29, 2025
| @@ -0,0 +1,3 @@ | |||
| [submodule "external/tinyxml2"] | |||
| path = external/tinyxml2 | |||
| url = https://github.com/leethomason/tinyxml2.git | |||
There was a problem hiding this comment.
Should we specify the v10.0.0 release branch here instead of just "latest from master"?
bahlborn
requested changes
Jan 30, 2025
|
Issue: This change puts the README out of date. We would need to add instructions for dealing with the submodules |
qjgn
requested changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the way that we include the Tinyxml2 libary.
Previous: FetchContent
New: Git Submodule