[Feature Branch] - CMarkup --> Tinyxml2 : SetGeneralSettings() #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qjgn
reviewed
Jan 31, 2025
| @@ -88,8 +88,8 @@ namespace qualisys_cpp_sdk { | |||
| private: | |||
| std::uint32_t mnMajorVersion; | |||
| std::uint32_t mnMinorVersion; | |||
| void AddXMLElementBool(tinyxml2::XMLDocument* oXML, const char* tTag, const bool* pbValue, const char* tTrue = "True", const char* tFalse = "False"); | |||
There was a problem hiding this comment.
Suggestion: These arguments are used in other places. Consider keeping them
qjgn
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces CMarkup with Tinyxml2 in the SetGeneralSettings() function.