Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds extra checks for bad Squiggle code #3399

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Adds extra checks for bad Squiggle code #3399

merged 1 commit into from
Oct 1, 2024

Conversation

OAGr
Copy link
Contributor

@OAGr OAGr commented Oct 1, 2024

No description provided.

@OAGr OAGr requested a review from berekuk as a code owner October 1, 2024 05:16
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2024

⚠️ No Changeset found

Latest commit: c4b8c66

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview Oct 1, 2024 5:18am
quri-ui ✅ Ready (Inspect) Visit Preview Oct 1, 2024 5:18am
squiggle-components ✅ Ready (Inspect) Visit Preview Oct 1, 2024 5:18am
squiggle-website ✅ Ready (Inspect) Visit Preview Oct 1, 2024 5:18am

@OAGr OAGr merged commit 0bb0a2c into main Oct 1, 2024
6 checks passed
@OAGr OAGr deleted the ai-additional-checks branch October 1, 2024 06:11
berekuk
berekuk reviewed Oct 7, 2024
View reviewed changes
packages/ai/src/squiggle/squiggleAutomaticChanges.ts
@@ -0,0 +1,14 @@
// replace |> with ->
function replacePipeWithArrow(code: string): string {
return code.replace(/\|>/g, "->");
Copy link
Collaborator

@berekuk berekuk Oct 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, does this still happen often?

I can't find any mentions of the old |> anywhere in the docs, did Claude read pre-0.8.0 Squiggle code somewhere on the internet?

|> is not a very popular version of a pipe operator, I guess it could come from OCaml, but that's surprising.

Copy link
Contributor Author

@OAGr OAGr Oct 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I was surprised too. Not sure where it got the idea from, maybe OCaml, or old online code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berekuk berekuk berekuk left review comments

Assignees
No one assigned
Labels
None yet
Projects
Main project
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OAGr @berekuk