feat: add accessible label wrapping for GFM task list checkboxes#792
Draft
feat: add accessible label wrapping for GFM task list checkboxes#792
Conversation
🦋 Changeset detectedLatest commit: 13f0a88 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
- Added unique IDs to checkboxes using React.useId (React 18+) with fallback counter - Wrapped checkbox labels in <label> elements with proper for/htmlFor attributes - Updated React, HTML, SolidJS, and Vue adapters for accessibility - Updated CommonMark spec expectations to reflect new accessible output Co-authored-by: quantizor <570070+quantizor@users.noreply.github.com>
…lity - Added comment explaining disabled vs readOnly attribute difference between HTML/React - Added comments explaining global counter behavior for ID generation - Added new tests for accessibility (id/for matching, formatted content in labels) Co-authored-by: quantizor <570070+quantizor@users.noreply.github.com>
Co-authored-by: quantizor <570070+quantizor@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix GFM checkboxes for semantic correctness
feat: add accessible label wrapping for GFM task list checkboxes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GFM task list checkboxes lack proper label association, causing accessibility issues flagged by Lighthouse and screen readers.
Changes
GfmTaskListItemcomponent usingReact.useId(18+) with counter fallback for unique IDs<label for="...">wrappingOutput
Before:
After:
Notes
disabledper GFM spec; React/Solid/Vue usereadOnlyfor better form handling_resetGfmTaskIdCounter()exposed for testingOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.