bugfix: 修复OpenAPI describe_git_releases_by_name内部传参异常

quanttide · Jul 5, 2022 · eb166ce · eb166ce
1 parent 07f933b
commit eb166ce
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 5 deletions.
diff --git a/coding_devops_sdk/openapi/client.py b/coding_devops_sdk/openapi/client.py
@@ -19,6 +19,8 @@ def __init__(self, team=None, token=None):
         """
         self.team = team or settings.TEAM
         self.token = token or settings.AUTH_TOKEN
+        if not self.token:
+            raise ValueError("鉴权令牌不可为空，请设置token参数或传入AUTH_TOKEN配置项。")
 
     def request_api(self, action, **kwargs):
         data = {'Action': action}

diff --git a/coding_devops_sdk/openapi/depot.py b/coding_devops_sdk/openapi/depot.py
@@ -54,9 +54,8 @@ def describe_project_depot_info_list_by_name(self, project_name: str) -> list:
 
     def get_depot_id_by_name(self, depot_name, project_name=settings.DEFAULT_PROJECT_NAME):
         """
-
-        :param project_name:
         :param depot_name:
+        :param project_name:
         :return:
         """
         if not project_name:
@@ -86,5 +85,5 @@ class IntegratedReleaseAPIMixin(object):
     def describe_git_releases_by_name(self, depot_name, project_name=settings.DEFAULT_PROJECT_NAME, **kwargs):
         if not project_name:
             raise ValueError("project name should be not empty, please set project_name either directly or on project settings")
-        depot_id = self.get_depot_id_by_name(project_name, depot_name)
+        depot_id = self.get_depot_id_by_name(depot_name=depot_name, project_name=project_name)
         return self.describe_git_releases(depot_id)
diff --git a/coding_devops_sdk/settings.toml b/coding_devops_sdk/settings.toml
@@ -1,2 +1,5 @@
+[default]
+# 默认项目
 DEFAULT_PROJECT_NAME = "@none None"
+# 默认仓库
 DEFAULT_DEPOT_NAME = "@none None"
diff --git a/pyproject.toml b/pyproject.toml
@@ -5,7 +5,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "coding-devops-sdk-py"
-version = "0.1.0"
+version = "0.1.1-beta.1"
 authors = [
     {name = "QuantTide Inc.", email = "opensource@quanttide.com"}
 ]

diff --git a/tests/test_openapi_depot.py b/tests/test_openapi_depot.py
@@ -17,8 +17,8 @@ def test_describe_project_depot_info_list_by_name(self):
 
     def test_get_depot_id_by_name(self):
         depot_id = coding_openapi_client.get_depot_id_by_name(
-            project_name=settings.TEST_PROJECT_NAME,
             depot_name=settings.TEST_DEPOT_NAME,
+            project_name=settings.TEST_PROJECT_NAME,
         )
         self.assertEqual(settings.TEST_DEPOT_ID, depot_id)